Re: [tsvwg] draft-ietf-udp-options issues from IETF 104

"C. M. Heard" <heard@pobox.com> Wed, 17 July 2019 20:13 UTC

Return-Path: <heard@pobox.com>
X-Original-To: tsvwg@ietfa.amsl.com
Delivered-To: tsvwg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E3BAE120047 for <tsvwg@ietfa.amsl.com>; Wed, 17 Jul 2019 13:13:43 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.698
X-Spam-Level:
X-Spam-Status: No, score=-2.698 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=pobox.com; domainkeys=pass (1024-bit key) header.from=heard@pobox.com header.d=pobox.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CtUv5qmkZ_Gc for <tsvwg@ietfa.amsl.com>; Wed, 17 Jul 2019 13:13:42 -0700 (PDT)
Received: from pb-smtp21.pobox.com (pb-smtp21.pobox.com [173.228.157.53]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 58BD8120018 for <tsvwg@ietf.org>; Wed, 17 Jul 2019 13:13:42 -0700 (PDT)
Received: from pb-smtp21.pobox.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 63CA9774BA for <tsvwg@ietf.org>; Wed, 17 Jul 2019 16:13:41 -0400 (EDT) (envelope-from heard@pobox.com)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=mime-version :references:in-reply-to:from:date:message-id:subject:to:cc :content-type; s=sasl; bh=BnMd6LV8IJX4chs6T8Y1xqEEYhg=; b=Z4pNnX fSL9INM0THdF0QnTQFpE4H2qddLhUZAR3ClBF1Tr6W9qesjz4nm7dPm7RIe1XiET SNjprVN274acM5syfkk8DkxnVBC9NbRdz3j1WKJrvtz7pHnWqAb4i7pk9s1p9hr+ lnVxhjWiR9MCnRFFCAsSsDfUI96IiP3aeXsks=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=mime-version :references:in-reply-to:from:date:message-id:subject:to:cc :content-type; q=dns; s=sasl; b=XP0NBApwymCbBRi4A5S8DxzqX0WnnXBD rCfIM5PacuStPBimbMtbE14tEKJ6ks8HgeNGSkPwrcu9hksjU+B4UeYBffMBVX7z lzCYfGB8Xkk1oX50H0/t62LUCn52LFx4OY3ZUAKHY0fO+AT5Nn9rXySw8cVYaJyZ kBdBlE+tU+0=
Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 5BF0E774B8 for <tsvwg@ietf.org>; Wed, 17 Jul 2019 16:13:41 -0400 (EDT) (envelope-from heard@pobox.com)
Received: from mail-io1-f53.google.com (unknown [209.85.166.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pb-smtp21.pobox.com (Postfix) with ESMTPSA id 0C182774B6 for <tsvwg@ietf.org>; Wed, 17 Jul 2019 16:13:39 -0400 (EDT) (envelope-from heard@pobox.com)
Received: by mail-io1-f53.google.com with SMTP id m24so47842505ioo.2 for <tsvwg@ietf.org>; Wed, 17 Jul 2019 13:13:39 -0700 (PDT)
X-Gm-Message-State: APjAAAXoSnxCe+7QEWQtU5Ma92R5d9u3r8rTmpTGZB1eeo+Z6rqjxpxX bInsBdzSUTi89ktXS9fEp1ys/sOc6W5bSHzD+LA=
X-Google-Smtp-Source: APXvYqzcnrDRBFLV9qfdoR4kBiVgQ5iLeR3ou4okaelupAYcPfAAzAfkO+seVI6sy/6fnUms1SxcW+nU/PdFiclhS0I=
X-Received: by 2002:a6b:8b8b:: with SMTP id n133mr37546359iod.183.1563394417928; Wed, 17 Jul 2019 13:13:37 -0700 (PDT)
MIME-Version: 1.0
References: <CAPDqMeq9GjEQKukH1pZOTdE50e_rc3U6gpdxT-5qrS5phD0RGw@mail.gmail.com> <646D45AD-D79B-4BD2-A084-7DA97CE2C415@strayalpha.com> <7EC37B50-45D5-4CF1-B113-205E55BF244E@strayalpha.com> <CALx6S34s7L7xo+26bt5Cdaqi4Es5Aci42GHk1WNKzugr5st-Gw@mail.gmail.com> <B525BF50-EFCC-44A5-A604-6CDDA914A1CB@strayalpha.com> <CAPDqMep3R6z9PRKkHyOvrh6sV9n5Sc0B++-zVz0FYJCwE6swrQ@mail.gmail.com> <E42A2AE2-F499-465E-BDE6-5EFC0AB20042@strayalpha.com> <CE03DB3D7B45C245BCA0D24327794936306138E9@MX307CL04.corp.emc.com> <CAPDqMeoyNb7vQTdqxLpZpnKb9S7QKeDJNLyQJBmq95yXhB+xfQ@mail.gmail.com> <7D365770-64FE-40BC-901D-B4D7DF6B484B@strayalpha.com> <20190713182554.GB39770@clarinet.employees.org> <CALx6S36mH2M6SYnRSecWXa7k_d1u8O43+CXE-=KqeO0x2e5+qw@mail.gmail.com> <82FF6486-FABF-4D2C-B5E2-178779C720A4@strayalpha.com> <30c17e9c174f6b0da3ecc6b503a8cb17@strayalpha.com> <CACL_3VGs7j+y5vFNT3OL9OKX8ue4rv-Cxi467KR-vbhnMdx86g@mail.gmail.com> <2f71a292f924a9b8de4227c4bbc2f809@strayalpha.com> <CACL_3VGrF5UnbVsSzZZoy1i57WKiQKBX2T3a16UyEVHY=Kr3XA@mail.gmail.com> <CE03DB3D7B45C245BCA0D243277949363061EF7A@MX307CL04.corp.emc.com> <CACL_3VE7+3WD3Uzubf8X9uQX9ZYPnZVhXjheUOuL9EfjT1JkGQ@mail.gmail.com> <CALx6S35V-d3Rn_wjrhbHUHgS=_+dVjR4hbMJ0-JBsG-1BuFuZg@mail.gmail.com> <B5CCEF58-38CE-4973-9CFD-002B404E4EF3@strayalpha.com>
In-Reply-To: <B5CCEF58-38CE-4973-9CFD-002B404E4EF3@strayalpha.com>
From: "C. M. Heard" <heard@pobox.com>
Date: Wed, 17 Jul 2019 13:13:26 -0700
X-Gmail-Original-Message-ID: <CACL_3VEnJoV9N9i59fJXG1Nyt=mMWT7SuB8B=C-Y9a9QLtqP7Q@mail.gmail.com>
Message-ID: <CACL_3VEnJoV9N9i59fJXG1Nyt=mMWT7SuB8B=C-Y9a9QLtqP7Q@mail.gmail.com>
To: Joe Touch <touch@strayalpha.com>
Cc: Tom Herbert <tom@herbertland.com>, tsvwg <tsvwg@ietf.org>
Content-Type: multipart/alternative; boundary="000000000000ecae08058de6207b"
X-Pobox-Relay-ID: 5D6CD43A-A8CF-11E9-8D3E-8D86F504CC47-06080547!pb-smtp21.pobox.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/tsvwg/JvMc_pmXpkzwMKu5dTIB_Inmn3s>
Subject: Re: [tsvwg] draft-ietf-udp-options issues from IETF 104
X-BeenThere: tsvwg@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Transport Area Working Group <tsvwg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tsvwg>, <mailto:tsvwg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tsvwg/>
List-Post: <mailto:tsvwg@ietf.org>
List-Help: <mailto:tsvwg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tsvwg>, <mailto:tsvwg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Jul 2019 20:13:44 -0000

On Tue, Jul 16, 2019 at 9:18 PM Joe Touch <touch@strayalpha.com> wrote:

> Hi, Tom, et al.,
>
> The checksum behavior as described in Sec 8. These were designed based on
> WG discussion to achieve the following properties:
>
> - presence of options should NEVER cause behavior different than at a
> legacy receiver
>         this is why if UDP CS passes but OCS fails, the UDP payload should
> still be passed to the user
>         i.e., it should never be a penalty to use options
>

I have no issue with that action.


> - individual options can cause the receiver to drop the packet when the
> option fails ONLY if both sides agree in advance
>         when that is NOT the case, the success/failure of the option is
> indicated to the user but UDP doesn’t made the decision
>

There is a counter-argument to this: when an option that affects payload
processing is present, and an options-aware implementation does not
understand it, ignoring it and passing the payload data to the application
is clearly incorrect. Such options need (a) to share fate with the payload
(i.e., be covered by the same checksum) and (b) must be marked in the KIND
as requiring that packet to be dropped if they are present. As I have
explained previously, fate-sharing, while unachievable with the protocol
trailer format but can be achieved with a protocol header packet format.


> What changed that makes these incorrect or insufficient?
>

Additionally, it is highly undesirable to loop though the option TLVs prior
to validating the OCS is undesirable.
draft-ietf-tsvwg-udp-options-07#section-8 doesn't account for that.

Admittedly it's taken me a while to figure this out, sorry that I am so
slow on the uptake. But serious bugs do need to be corrected, even if they
are discovered late.

Mike