IETF Logo Mail Archive

[quicwg/base-drafts] lost_pn can no longer be negative (#2621)

ianswett <notifications@github.com> Mon, 15 April 2019 15:38 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C60F3120390 for <quic-issues@ietfa.amsl.com>; Mon, 15 Apr 2019 08:38:36 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vzf1Q6WbAJ7w for <quic-issues@ietfa.amsl.com>; Mon, 15 Apr 2019 08:38:35 -0700 (PDT)
Received: from out-9.smtp.github.com (out-9.smtp.github.com [192.30.254.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 84ED212004D for <quic-issues@ietf.org>; Mon, 15 Apr 2019 08:38:35 -0700 (PDT)
Date: Mon, 15 Apr 2019 08:38:34 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1555342714; bh=ualAKEBvlhP+1Q5My5TxieJxd7TXaW7Kyt5f/U5g2+o=; h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=x9x9AtOAJk+5QWtIbqSRugT67uKAZko0R1WtEpVLN7UVjlRg0kg/QY0t2XMf2XGfE iSodfZgj41jIax4VT648wsl/Xl03L+oDQst9BsJETqTnMCcsmlZZOJlWg8iufze4a+ +bCafe7dR3jxItFHlb1LEdX98VxEtGmo91avICjw=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab3c90731b1fc7e4db87dc3a1e3886fa3e8bd7135592cebac1d7fa92a169ce19d467b3@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2621@github.com>
Subject: [quicwg/base-drafts] lost_pn can no longer be negative (#2621)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cb4a57ab322f_69573fc0818d45c43465a4"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/UjhnGsm-w1YGl0k2mMsbDQHcm30>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 15 Apr 2019 15:38:37 -0000

And 0 is a valid packet number, so defaulting largest_acked_packet to 0 is inherently incorrect.

Fixes #2611
You can view, comment on, or merge this pull request online at:

  https://github.com/quicwg/base-drafts/pull/2621

-- Commit Summary --

  * lost_pn can no longer be negative

-- File Changes --

    M draft-ietf-quic-recovery.md (5)

-- Patch Links --

https://github.com/quicwg/base-drafts/pull/2621.patch
https://github.com/quicwg/base-drafts/pull/2621.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2621

v2.8.10 | Report a Bug | By Email