Re: [Wish] WG Last Call for draft-ietf-wish-whip

Bernard Aboba <bernard.aboba@gmail.com> Tue, 28 February 2023 20:09 UTC

Return-Path: <bernard.aboba@gmail.com>
X-Original-To: wish@ietfa.amsl.com
Delivered-To: wish@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 20F0BC1527A6 for <wish@ietfa.amsl.com>; Tue, 28 Feb 2023 12:09:15 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.204
X-Spam-Level:
X-Spam-Status: No, score=-1.204 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, MIME_HTML_ONLY=0.1, MIME_HTML_ONLY_MULTI=0.001, MIME_QP_LONG_LINE=0.001, MPART_ALT_DIFF=0.79, RCVD_IN_DNSWL_BLOCKED=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id v7s3-H9uY4Wu for <wish@ietfa.amsl.com>; Tue, 28 Feb 2023 12:09:10 -0800 (PST)
Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D74E1C1524C8 for <wish@ietf.org>; Tue, 28 Feb 2023 12:09:10 -0800 (PST)
Received: by mail-pj1-x1036.google.com with SMTP id m8-20020a17090a4d8800b002377bced051so14952380pjh.0 for <wish@ietf.org>; Tue, 28 Feb 2023 12:09:10 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:in-reply-to:cc:references:message-id:date:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=fsKnL3F9o252fFVvcWeVNcoChT+iBXW6c+dOVfU2BPY=; b=Nl+wRnMytunll9gYBYGVzwnIzr9dDeC2X3WLCSnC9fkjVDeKjPfeWect0QjkzMQlWc MO3BrE/0Vh0ASXr/vdBq+/Les6rsCKdoTzv4W/rEQQi8HvWrQhxX14psJdTUdyJMY005 ZCF4xQAk7j2wRCcZUBvza8x1W9aw4cRdw7/SCy+9ZsxoWAeL5BQmpx6MgG9R/fcaHse/ GZPFtNVU1jMTU6IcTMSg6cpdFeOhil0IAyM4aXPUZ4E3AuwuLO3JGDWkwkVpKHGDfHr5 HBWWE9YIIQs5xWVtBoZXK9cmh9yBrPl5wSIEfo8DiJ5nsJCBT7XR++ssMg+uJUBjbeEk zrvA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:in-reply-to:cc:references:message-id:date:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fsKnL3F9o252fFVvcWeVNcoChT+iBXW6c+dOVfU2BPY=; b=wE0aewGj3WwN1fDW/WnElA351bajz5OoY/6W6/b+XPllymLwdxk4QDwjAZDMXo38w7 Iw3hD7342VL87JtV68LbuIB6Up8oqK332vw6Q5KIHoDSQB/htPvmAL/jcd8c2nAB89vI g5wRZINYKvteLuh8cQ+bO9+/dx2rltsvswCHDWwOfdj+woEY8cwdWM+n7l7dD1IoAY+N Ue0zP2zvaaDIvwA9gZqJ0+Big1aWAZAaM0NZTYJOAb+puzVliDyXEJQ/isw5JWW76l7Z ge9taprpYuVeQtBR5QAuC9jGnSYEdT6ojPqT8TEVzLdbvRR+PGBMIfLUrkyLKDUGyPwR 5I1Q==
X-Gm-Message-State: AO0yUKWtwPJbcQcrDFCemuB3G7jC2NRGIF9qpKXwjMHrj9UsQLck53/+ ie3HGTj77Do906IGXO+wCqpXjkZ1CQI=
X-Google-Smtp-Source: AK7set+uPcEm3Vl1v0jZl1tlcFQLPhIS9pT389dUDPXMKxwNMJSM3ONTMEbh7MSTOVeU7G8X3N1Pww==
X-Received: by 2002:a17:902:da83:b0:19a:f02c:a05b with SMTP id j3-20020a170902da8300b0019af02ca05bmr4126875plx.3.1677614949369; Tue, 28 Feb 2023 12:09:09 -0800 (PST)
Received: from smtpclient.apple ([2600:380:7074:e450:2494:9576:c783:ae38]) by smtp.gmail.com with ESMTPSA id ik19-20020a170902ab1300b00194c1281ca9sm6919187plb.166.2023.02.28.12.09.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Feb 2023 12:09:08 -0800 (PST)
From: Bernard Aboba <bernard.aboba@gmail.com>
X-Google-Original-From: Bernard Aboba <Bernard.Aboba@gmail.com>
Content-Type: multipart/alternative; boundary="Apple-Mail-4543BEF0-3E6E-4C4B-B402-6272D504414E"
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (1.0)
Date: Tue, 28 Feb 2023 12:08:56 -0800
Message-Id: <B29BF8C4-8A15-4091-9402-4D063E62EF84@gmail.com>
References: <CA+ag07afe3oYQW=UzCruQtqntNhLuQsAi9XmfUNEbRCWBNPEaw@mail.gmail.com>
Cc: wish@ietf.org
In-Reply-To: <CA+ag07afe3oYQW=UzCruQtqntNhLuQsAi9XmfUNEbRCWBNPEaw@mail.gmail.com>
To: Sergio Garcia Murillo <sergio.garcia.murillo@gmail.com>
X-Mailer: iPhone Mail (20D67)
Archived-At: <https://mailarchive.ietf.org/arch/msg/wish/EwcRD07AaxDmTYix4dXdJSUiOvM>
Subject: Re: [Wish] WG Last Call for draft-ietf-wish-whip
X-BeenThere: wish@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: WebRTC Ingest Signaling over HTTPS <wish.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/wish>, <mailto:wish-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/wish/>
List-Post: <mailto:wish@ietf.org>
List-Help: <mailto:wish-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/wish>, <mailto:wish-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Feb 2023 20:09:15 -0000

Comments below.

On Feb 28, 2023, at 05:48, Sergio Garcia Murillo <sergio.garcia.murillo@gmail.com> wrote:



Hi Bernard,

Thank you very much for your feedback, comments below inline.

On Fri, Feb 24, 2023 at 10:56 PM Bernard Aboba <bernard.aboba@gmail.com> wrote:
Here is my (belated) review. 

Section 1

 While WebRTC has been very successful in a wide range of scenarios,
   its adoption in the broadcasting/streaming industry is lagging 
   behind.

[BA] I recently saw a survey indicating that WHIP is now the second most implemented ingestion protocol, second only to RTMP.  So while this sentence may have been correct at one time, it seems out of date now.  Can we delete this sentence? 

Also, overall Section 1 seems like it could be shortened considerably by highlighting the major points. Here is my suggestion: 


I am ok with changing the introduction, will review your text and propose a PR with your changes.

[BA] Sounds good.

 
Section 2

I do not see a definition of “track”.  I think this is important to clarify. 

 I already had a PR related to that adding a reference to RFC8830.


Do you think it would be enough?

[BA] I would also add a definition for “track”.

Yes, this is definitely possible, see me comment about using track as defined in RFC8830. Given that stereo and surround sound are SDP negotiated, do you think that we need to include any further clarification apart of the track one?

[BA] I think that’s all that is needed.

 I agree with you, should we remove the reference to SVC completely and only leave simulcast support in that section?

[BA] That would make sense. Only thing to worry about might be ingestors that can’t handle reference scaling (e.g. spatial modes) but that’s an edge case that might be not be encountered in practice.


Best regards
Sergio