Re: [Wish] WG Last Call for draft-ietf-wish-whip

Bernard Aboba <bernard.aboba@gmail.com> Wed, 08 March 2023 15:47 UTC

Return-Path: <bernard.aboba@gmail.com>
X-Original-To: wish@ietfa.amsl.com
Delivered-To: wish@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5912DC151546 for <wish@ietfa.amsl.com>; Wed, 8 Mar 2023 07:47:55 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.094
X-Spam-Level:
X-Spam-Status: No, score=-2.094 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, MIME_QP_LONG_LINE=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id z1N2iPkebv0X for <wish@ietfa.amsl.com>; Wed, 8 Mar 2023 07:47:51 -0800 (PST)
Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 997D7C151555 for <wish@ietf.org>; Wed, 8 Mar 2023 07:47:51 -0800 (PST)
Received: by mail-pj1-x1031.google.com with SMTP id me6-20020a17090b17c600b0023816b0c7ceso2822900pjb.2 for <wish@ietf.org>; Wed, 08 Mar 2023 07:47:51 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678290471; h=to:in-reply-to:cc:references:message-id:date:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=cTQvfvEKFYjE+HxZ0ZNDC9jsbpEOljc5O3jRbFat6YI=; b=cWMLGb+Y8xiRpcRhuTYAS0/x6epptdR9I1y7tf/FcHw3xn25nsPHYze5fDeOMxzs4Q dhCFoXebuaxvaw8U72QWzZwMLBsimmD1VHLQc4su5sG4nCzhvkJo1Nw4OMMUaI+5ck+I ItWLC1AV0+1VFFxu/Ky5ZjKxX78YpkaQfn8PylMfqk5vbZafMtydsCAFrqpaiSexGFuX CLh3INF8fh8hqok2pLAt4NicUxWI4CkP5RHcHsAmQB9I/ZTdJu9asQbILgkwdkYfivCl 3lDzDbtdr3q9D1ZCtffGP8DpL+2FI+6Dvv5by+KDXD6qMz3XzmnUhBeIkA/pvEnUNO0K VIVw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678290471; h=to:in-reply-to:cc:references:message-id:date:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cTQvfvEKFYjE+HxZ0ZNDC9jsbpEOljc5O3jRbFat6YI=; b=WMKXNAUytIxnmO3T485dXbI7jdLBSXdnMVDgHTqlvbgioSv1bYpyqdbU6Thn02X2H9 gaJIQRl/LYq2RI/f03m1RNRCqNXQPHMKjEVUTWe+jqQN4XudTK2KVa2Xh+vrtiyS4ndD Uev/XZy7xMK6iRgtJHKtdJsADpimfyZXaAAWc8zV+scagbGN2LbshtMjwoi5Mnvz91Ig ZphMIgiPBdVy6ZKwy9r4gFYkWhtnyk6Gn//aG+LeZYAsXA6IeD3bXCBEBi5Y5UzLv0qF sYFXP+W8JkEgsU1NTdIt/6Mwa6ZZQam628mQhVqB3vUb9Ute7C62cJIEiN7Y7wy2NKjR 7yUg==
X-Gm-Message-State: AO0yUKWuBcYyS1W0Ed25SvwIMsoAmNqezjg4QNM2DFlKlqAAmXYZyr0v 1LdqJW3Pf2v0Vyo88XnIVq2YakXW/0GGCij+
X-Google-Smtp-Source: AK7set+Vl2mYqWZUWdir7fNqEU0t5Los48pKt3CF5ehm+yG3OMIABSY3dSpO2OJHbPSeQbC0oUQbuw==
X-Received: by 2002:a17:902:cf06:b0:19e:6dda:6e4d with SMTP id i6-20020a170902cf0600b0019e6dda6e4dmr18503400plg.18.1678290470142; Wed, 08 Mar 2023 07:47:50 -0800 (PST)
Received: from smtpclient.apple (c-24-16-156-188.hsd1.wa.comcast.net. [24.16.156.188]) by smtp.gmail.com with ESMTPSA id l11-20020a17090270cb00b00194caf3e975sm9877009plt.208.2023.03.08.07.47.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Mar 2023 07:47:49 -0800 (PST)
From: Bernard Aboba <bernard.aboba@gmail.com>
X-Google-Original-From: Bernard Aboba <Bernard.Aboba@gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (1.0)
Date: Wed, 08 Mar 2023 07:47:38 -0800
Message-Id: <7E4F238B-CB29-43F1-8E19-145AD6C7CA6D@gmail.com>
References: <ABB150AD-2F30-4BB4-BFEA-29322939A7DC@sn3rd.com>
Cc: Sergio Garcia Murillo <sergio.garcia.murillo@gmail.com>, WISH List <wish@ietf.org>
In-Reply-To: <ABB150AD-2F30-4BB4-BFEA-29322939A7DC@sn3rd.com>
To: Sean Turner <sean@sn3rd.com>
X-Mailer: iPad Mail (20D67)
Archived-At: <https://mailarchive.ietf.org/arch/msg/wish/mMZKef_LaWyuGmKTKUVIJaPz4cI>
Subject: Re: [Wish] WG Last Call for draft-ietf-wish-whip
X-BeenThere: wish@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: WebRTC Ingest Signaling over HTTPS <wish.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/wish>, <mailto:wish-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/wish/>
List-Post: <mailto:wish@ietf.org>
List-Help: <mailto:wish-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/wish>, <mailto:wish-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Mar 2023 15:47:55 -0000

PRs 95 and 96 look good.

On PR 98:

WebRTC conferencing servers commonly send an Offer to receive simulcast, which includes the maximum number of streams that the server can support. In WHIP, it does not seem like the ingester can send an Offer to receive to the encoder. So I guess that the encoder has to look at the Answer to understand the ingester limitations (e.g. encoder asked to send 3 streams, ingester answered with 2)?

With respect to SVC, the issue is really what the decoder can handle. For example, software decoders for VP8, VP9 and AV1 can typically decode any legal encoding, and H.264/AVC software decoders can commonly handle temporal scalability. 

Hardware decoders and transcoders are a different story; they can lack of support for reference scaling, which prevents decoding spatial scalability (or even changing resolution without a key frame). 

So I might say “decoder specific” rather than “codec specific”. 

> On Mar 8, 2023, at 07:22, Sean Turner <sean@sn3rd.com> wrote:
> 
> Sergio: Thanks for the work here.
> Bernard: Would really appreciate the review so that we can get the new I-D in before Monday’s submission deadline.
> 
> Cheers,
> spt
> 
>> On Mar 8, 2023, at 09:06, Sergio Garcia Murillo <sergio.garcia.murillo@gmail.com> wrote:
>> 
>> Hi Bernard,
>> 
>> I have created 3 PRs addressing your feedback:
>> 
>> https://github.com/wish-wg/webrtc-http-ingest-protocol/pulls
>> 
>> Could you review them and let me know if you are happy with the changes?  I plan to submit a new draft by the end of the week.
>> 
>> Best regards
>> Sergio
>> 
>> 
>> On Tue, Feb 28, 2023 at 9:09 PM Bernard Aboba <bernard.aboba@gmail.com> wrote:
>> Comments below.
>> 
>>>> On Feb 28, 2023, at 05:48, Sergio Garcia Murillo <sergio.garcia.murillo@gmail.com> wrote:
>>> 
>>> 
>>> 
>>> Hi Bernard,
>>> 
>>> Thank you very much for your feedback, comments below inline.
>>> 
>>>> On Fri, Feb 24, 2023 at 10:56 PM Bernard Aboba <bernard.aboba@gmail.com> wrote:
>>> Here is my (belated) review. 
>>> 
>>> Section 1
>>> 
>>> “ While WebRTC has been very successful in a wide range of scenarios,
>>>   its adoption in the broadcasting/streaming industry is lagging 
>>>   behind.”
>>> 
>>> [BA] I recently saw a survey indicating that WHIP is now the second most implemented ingestion protocol, second only to RTMP.  So while this sentence may have been correct at one time, it seems out of date now.  Can we delete this sentence? 
>>> 
>>> Also, overall Section 1 seems like it could be shortened considerably by highlighting the major points. Here is my suggestion: 
>>> 
>>> 
>>> I am ok with changing the introduction, will review your text and propose a PR with your changes.
>> 
>> [BA] Sounds good.
>> 
>>> 
>>> Section 2
>>> 
>>> I do not see a definition of “track”.  I think this is important to clarify. 
>>> 
>>> I already had a PR related to that adding a reference to RFC8830.
>>> 
>>> https://github.com/wish-wg/webrtc-http-ingest-protocol/pull/95
>>> 
>>> Do you think it would be enough?
>> 
>> [BA] I would also add a definition for “track”.
>> 
>>> Yes, this is definitely possible, see me comment about using track as defined in RFC8830. Given that stereo and surround sound are SDP negotiated, do you think that we need to include any further clarification apart of the track one?
>> 
>> [BA] I think that’s all that is needed.
>> 
>>> I agree with you, should we remove the reference to SVC completely and only leave simulcast support in that section?
>> 
>> [BA] That would make sense. Only thing to worry about might be ingestors that can’t handle reference scaling (e.g. spatial modes) but that’s an edge case that might be not be encountered in practice.
>> 
>>> 
>>> Best regards
>>> Sergio
>> -- 
>> Wish mailing list
>> Wish@ietf.org
>> https://www.ietf.org/mailman/listinfo/wish
>