IETF Logo Mail Archive

Re: [quicwg/base-drafts] Rearrange Packet Types section and references (#2203)

Mike Bishop <notifications@github.com> Wed, 19 December 2018 19:49 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 377F3130EC6 for <quic-issues@ietfa.amsl.com>; Wed, 19 Dec 2018 11:49:21 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.661
X-Spam-Level:
X-Spam-Status: No, score=-6.661 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eP9Zu2-EhVZy for <quic-issues@ietfa.amsl.com>; Wed, 19 Dec 2018 11:49:19 -0800 (PST)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8DD881200B3 for <quic-issues@ietf.org>; Wed, 19 Dec 2018 11:49:19 -0800 (PST)
Date: Wed, 19 Dec 2018 11:49:18 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1545248958; bh=bCo/+nzRMeU3dpH8pncIg8KphcH4O/lBOBfl8zYAbR4=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=U9GZQu0UYijeUA9ytxKDSVtd1Q+xHkVBve7onNSmqiGaqkuj8YjU3uswj9oGzdGjg dljUjB9q2krh3OCbK5/58cVmaIVDbavcIWji+Xz9AqA8zkHC6grSwdff7J/5zB3GdT m2iHiPl/9S7pe4+wwefD5nq2WEV7Pd2e0cl/Qc6c=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab4a0d6a492f2f356c2ad0a9ce42dc94689158349992cf00000001183262be92a169ce175c9b40@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2203/review/186719659@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2203@github.com>
References: <quicwg/base-drafts/pull/2203@github.com>
Subject: Re: [quicwg/base-drafts] Rearrange Packet Types section and references (#2203)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c1aa0be74e0d_75d33ff15cad45c0368459"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/zObQo21tMFn8akH8XeE3h4qHjIA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Dec 2018 19:49:21 -0000

MikeBishop commented on this pull request.



> @@ -3674,7 +3707,37 @@ Token Length:
 
 Token:
 
-: The value of the token.
+: The value of the token that was previously provided in a Retry packet or

You're right, this fell in during the ELH combination.  So Initial packets *are* different because of the Token fields, which means that only 0-RTT and Handshake have the same ELH format.  Are we sure it's worth not simply having an explicit list of fields for those two?  That makes me more inclined to just revert the ELH change entirely and make each long-header packet type stand alone.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2203#discussion_r243052578

v2.23.0 | Report a Bug | By Email