IETF Logo Mail Archive

Re: [Idr] Fwd: New Version Notification for draft-spaghetti-idr-bgp-sendholdtimer-05.txt

Nick Hilliard <nick@foobar.org> Sat, 30 July 2022 23:40 UTC

Return-Path: <nick@foobar.org>
X-Original-To: idr@ietfa.amsl.com
Delivered-To: idr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CEDDCC14F741 for <idr@ietfa.amsl.com>; Sat, 30 Jul 2022 16:40:42 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.909
X-Spam-Level:
X-Spam-Status: No, score=-1.909 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_BLOCKED=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oHoIqbdJpv_Z for <idr@ietfa.amsl.com>; Sat, 30 Jul 2022 16:40:41 -0700 (PDT)
Received: from mail.netability.ie (mail.netability.ie [IPv6:2a03:8900:0:100::5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3741BC14F73B for <idr@ietf.org>; Sat, 30 Jul 2022 16:40:40 -0700 (PDT)
Received: from crumpet.local (admin.ibn.ie [46.182.8.8]) by mail.netability.ie (Postfix) with ESMTPSA id 41F389D46D; Sun, 31 Jul 2022 00:40:36 +0100 (IST)
To: Job Snijders <job=40fastly.com@dmarc.ietf.org>
Cc: "idr@ietf. org" <idr@ietf.org>
References: <165920076221.43110.14224170878306367770@ietfa.amsl.com> <CAMFGGcC19MJ4poutfp_C-=14RjQeNQXgc24vHyXoQsdZLNq5PQ@mail.gmail.com>
From: Nick Hilliard <nick@foobar.org>
Message-ID: <1cb64c4d-b0ea-747c-7eb9-f28f5d399361@foobar.org>
Date: Sun, 31 Jul 2022 00:40:34 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:52.0) Gecko/20100101 PostboxApp/7.0.56
MIME-Version: 1.0
In-Reply-To: <CAMFGGcC19MJ4poutfp_C-=14RjQeNQXgc24vHyXoQsdZLNq5PQ@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/WL_6PvWgeclC3eO7LNBd-0bpXtE>
Subject: Re: [Idr] Fwd: New Version Notification for draft-spaghetti-idr-bgp-sendholdtimer-05.txt
X-BeenThere: idr@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Inter-Domain Routing <idr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/idr>, <mailto:idr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr/>
List-Post: <mailto:idr@ietf.org>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/idr>, <mailto:idr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 30 Jul 2022 23:40:42 -0000

Job Snijders wrote on 30/07/2022 18:23:
> I’d like to bring this draft to the working group for another round of 
> consideration for WG adoption.

seems like a good idea for adoption.  Some suggestions:

1. it's blindingly obvious, but it may be helpful to state that 
SendHoldTimer must be >= HoldTimer.

2. The text in section 4 needs to be clarified, e.g.

> If a local system detects that it cannot send KEEPALIVE, UPDATE,
> and/or NOTIFICATION messages to a remote system within the period
> specified in the SendHold Time, then the BGP connection is closed on
> the local system and a log message is emitted.

The "or receive" text is superfluous - this is already covered by HoldTimer.

3. maybe add something to SendHoldTimer_Expires logic to expose the 
error notification code in snmp / etc (i.e. similar to 
draft-ietf-idr-bfd-subcode).

Nick

v2.23.0 | Report a Bug | By Email