Re: [Idr] New Version Notification for draft-spaghetti-idr-bgp-sendholdtimer-05.txt

Job Snijders <job@fastly.com> Fri, 19 August 2022 09:24 UTC

Return-Path: <jsnijders@fastly.com>
X-Original-To: idr@ietfa.amsl.com
Delivered-To: idr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1EAB6C157B3A for <idr@ietfa.amsl.com>; Fri, 19 Aug 2022 02:24:42 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.105
X-Spam-Level:
X-Spam-Status: No, score=-7.105 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=fastly.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 18eAQ-3ILp4q for <idr@ietfa.amsl.com>; Fri, 19 Aug 2022 02:24:38 -0700 (PDT)
Received: from mail-io1-xd34.google.com (mail-io1-xd34.google.com [IPv6:2607:f8b0:4864:20::d34]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3B2FEC157B39 for <idr@ietf.org>; Fri, 19 Aug 2022 02:24:38 -0700 (PDT)
Received: by mail-io1-xd34.google.com with SMTP id c4so2065526iof.3 for <idr@ietf.org>; Fri, 19 Aug 2022 02:24:38 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=p57yAn1wKgdrToXvsh9Buaae9mjk3JdgN14RS/dUmso=; b=K59fQgLsUPyPL/xFWC1mly2hHmWmXBAewh4G4G/C3LGrZHDaVkYM3xF2ZEC8sDadN2 90cdz+4sG6V4bFvhfsS0+8vwRVSidHybfEBRBW5oFYDPOzCnzdm3VUg5R4JWfguyz/G+ jdGpgOOrIn7AK/HBwA8vL1upIOczAROO+7Kl4=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=p57yAn1wKgdrToXvsh9Buaae9mjk3JdgN14RS/dUmso=; b=74ujng7VljStvmoF3xGapPWcxkbJloRjRifUqzAYeYJkbetYB929wUNf0l0qmSZ04T H3Mw+e6ruMsJATg4sc7EUfcyMJ3XgsZd4rEhRG3g3Y9E6/MQ3goRtOHmGz22kGqDgEfP 8DTl+3toBSzRtB/vSwK45FwZQi/LeE/vnA457d603b5y9RvHarqqjb2sNEDdPSE4OmmV oyH4WXm2r76YCD+N0ag4PRvUzdH5e+yYF+5ogdGYCE6gRQf3X32MgZ2HHW7F37RMUG/+ nPYUcbIVxRyg+/974dynX4TKBNZFNDFTuFsDUK3Q0+AOmFNaGp+Tw9EdKxNFtk8RyZxT N7MA==
X-Gm-Message-State: ACgBeo2qp4OeBKMGu7BFmuYTxcL02yrenZmyU1eThBHMVZGoKgdmMG4o 3vqdnh/ZB8jq2CA4t9dJEZUM0XINSzRenONkxSSEQw==
X-Google-Smtp-Source: AA6agR4R/cHDdkEUm9bj4VTZ/fo8ObHCAe61McosVySr4gFBMvBXf1LXjgjjl0K3PGtfqvvM2hD8feCbnLNTOTP7dJc=
X-Received: by 2002:a02:620c:0:b0:343:5e87:1bae with SMTP id d12-20020a02620c000000b003435e871baemr2046806jac.100.1660901077281; Fri, 19 Aug 2022 02:24:37 -0700 (PDT)
MIME-Version: 1.0
References: <CAMFGGcC19MJ4poutfp_C-=14RjQeNQXgc24vHyXoQsdZLNq5PQ@mail.gmail.com> <CABNhwV0b6ODL8u+VG8aYLRD9vQxwupYQT5DL0wBfZoOx-oCsZg@mail.gmail.com> <CABNhwV2v4h2Sr_jKOUPsr-jdq-SbpD7xOLsazZC8zT3J3os_Ow@mail.gmail.com> <CAOj+MMFxHoZ8=gsF3bHho+CRp3XPo4=2WSp_jAvWSXzFzOr74Q@mail.gmail.com> <Yvo2FEBH6tM3ttKd@diehard.n-r-g.com> <CAOj+MMGTQSOYbd6g55vquzBoE2EEGMu4QSMDpYSTWvFhX4+BHg@mail.gmail.com> <CAEm8Q11M35gp=m2pMjnQ_RnQ4S_Otx4wugwx03QRPDvCzMWcyw@mail.gmail.com> <CAOj+MMEdWr4mnp0Cr9QSQ+Msfb6jHwziu=ttPGhdXUrtgtZqBw@mail.gmail.com> <Yvp3eZ4iDccWNmIR@shrubbery.net> <CAOj+MMER5fTqyyXhFB0VkL51CHKC81=DNfGeqtHqPEcAgS0LBw@mail.gmail.com> <Yvq12HOd+1HPPa/t@shrubbery.net> <CAOj+MMFNVM7TrpGGrreWufkP97X0n0W11y2eOsnss+v5irE62g@mail.gmail.com> <AM7PR07MB6248651F07184633E93B1144A06A9@AM7PR07MB6248.eurprd07.prod.outlook.com> <83BA8ED7-3ABF-4079-AFC5-F9F60CEA9668@pfrc.org>
In-Reply-To: <83BA8ED7-3ABF-4079-AFC5-F9F60CEA9668@pfrc.org>
From: Job Snijders <job@fastly.com>
Date: Fri, 19 Aug 2022 11:24:26 +0200
Message-ID: <CAMFGGcBtiYzvbpDiHZ151DRva+xNz8RQHWiQPiGP+fR9tq9aTA@mail.gmail.com>
To: Jeffrey Haas <jhaas@pfrc.org>
Cc: John Heasley <heas@shrubbery.net>, "idr@ietf. org" <idr@ietf.org>, tom petch <ietfc@btconnect.com>
Content-Type: multipart/alternative; boundary="000000000000b816e305e694aa7a"
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/X6PTFqVoHE81_oyXKteWEBjUIRw>
Subject: Re: [Idr] New Version Notification for draft-spaghetti-idr-bgp-sendholdtimer-05.txt
X-BeenThere: idr@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Inter-Domain Routing <idr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/idr>, <mailto:idr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr/>
List-Post: <mailto:idr@ietf.org>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/idr>, <mailto:idr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 19 Aug 2022 09:24:42 -0000

Hi all,

I’ve added some bits where to restart the Send Hold Timer:
https://www.ietf.org/rfcdiff?url2=draft-spaghetti-idr-bgp-sendholdtimer-08.txt

I believe the suggested FSM update and the three known implementations are
in line with each other.

Further tuning (such as the notion of asynchronously started timers) can
happen as a Working Group document, including writing out a full copy of
the FSM description in an Appendix (as the “update this update that add
this” style of writing quickly becomes unwieldy).

Kind regards,

Job

On Wed, 17 Aug 2022 at 15:26, Jeffrey Haas <jhaas@pfrc.org> wrote:

>
>
> > On Aug 17, 2022, at 6:48 AM, tom petch <ietfc@btconnect.com> wrote:
> >
> > From: Idr <idr-bounces@ietf.org> on behalf of Robert Raszuk <
> robert@raszuk.net>
> > Sent: 15 August 2022 22:18
> >
> > https://mailarchive.ietf.org/arch/msg/idr/McRvkJ6UiNwJSKvGs0GPaqDfovA/
> >
> > #1 - IMO it would be a pretty bad idea to apply Send_Hold_Timer to a
> booting node. If at all this timer should fire only after receiving the
> <EOR> marker on the session.
> >
> > #2 - Authors of this draft target cases where a peer is stuck for
> "days/weeks" ... I am yet to see a BGP node taking that much to boot.
> >
> > <tp>
> > At a slight tangent, the I-D fails to state when the timer should be
> running, in which of the FSM states, which leaves much to the imagination.
> Since this is a function of TCP and not BGP, then it could be applicable as
> soon as there is a TCP connection and so apply to most state.
>
> This detail is one of the things that has me uneasy about blanketly
> applying the example feature Enke Chen highlighted from the Linux option.
>
> The challenge being faced is when BGP decides that the remote side is
> "taking too long".  Initial startup scenarios where the firehose of a RIB
> exchange are one of the places where a little forgiveness in timers may be
> reasonable.  This is especially true if you're looking at some sort of
> larger outage where every single device in a "region" may be trying to
> restart simultaneously.
>
> Relevant to your point, Tom, figuring out the exact touch point in the FSM
> to hook this is challenging enough.  If we permit an implementation to turn
> it on "later" at a point subjective to the implementation, the FSM isn't
> exactly good about that right now.  It'd become an asynchronously started
> timer.
>
> -- Jeff (still cursing Alex for the FSM)
> _______________________________________________
> Idr mailing list
> Idr@ietf.org
> https://www.ietf.org/mailman/listinfo/idr
>