IETF Logo Mail Archive

Re: [quicwg/base-drafts] Persistent Congestion Time Threshold (#2365)

Nick Banks <notifications@github.com> Thu, 07 February 2019 19:50 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BCA8612D4ED for <quic-issues@ietfa.amsl.com>; Thu, 7 Feb 2019 11:50:22 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.383
X-Spam-Level:
X-Spam-Status: No, score=-1.383 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id H2ZawVc4erEu for <quic-issues@ietfa.amsl.com>; Thu, 7 Feb 2019 11:50:21 -0800 (PST)
Received: from o5.sgmail.github.com (o5.sgmail.github.com [192.254.113.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3BE8A12D4EC for <quic-issues@ietf.org>; Thu, 7 Feb 2019 11:50:21 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=K8kpvUo6YPP1JTVr7qQKqq1/Wc4=; b=kIgOhx78ngywCYYp wQLFpi1vQ9gxR96v3uG19xSvM1IzIZq80TKDHEpx8TqBjEId8kIZ16lalOVHAqKC CwDp6gWV/Ju23cgsD3tMQsi5eG4erOzyJJO25imswnKBoC7CgJwjuR9PVBFcJ+54 RrCKXoJgfntussDXQdvtXS4hcy8=
Received: by filter1354p1mdw1.sendgrid.net with SMTP id filter1354p1mdw1-20804-5C5C8BFC-5 2019-02-07 19:50:20.093454544 +0000 UTC m=+160920.045994055
Received: from github-lowworker-5909e27.cp1-iad.github.net (unknown [192.30.252.35]) by ismtpd0006p1iad2.sendgrid.net (SG) with ESMTP id -eOT7ME8RQ6pmxitOKJcuQ for <quic-issues@ietf.org>; Thu, 07 Feb 2019 19:50:20.003 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-5909e27.cp1-iad.github.net (Postfix) with ESMTP id 0082D3E006F for <quic-issues@ietf.org>; Thu, 7 Feb 2019 11:50:19 -0800 (PST)
Date: Thu, 07 Feb 2019 19:50:20 +0000
From: Nick Banks <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab24a489c00463c8bd6e732e2c8f2cb77ed6b93fed92cf0000000118744dfb92a169ce17fab1f6@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2365/review/201290131@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2365@github.com>
References: <quicwg/base-drafts/pull/2365@github.com>
Subject: Re: [quicwg/base-drafts] Persistent Congestion Time Threshold (#2365)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c5c8bfbeef8e_5a8b3f8b2b0d45bc405341"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: nibanks
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0lpFgG5xTLdKcp5zAwuIZQT7t9aVxXmqx/3b opMAD+XJQmXuB+IKdx5ZJB5OUNblU7t9ETEWemsIPKNiPPigOWt0Zs7rj8eO1bzrVa/LD5Vl6fjKZa 6xR6UP2EOCwJAGzYFQgDapkBiC69zsDSOWkW/XBThGmtD/c7nU49stJC1fRnbQUjkHrF8fSXjx33yS I=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/KvxsoKdsjrcu_5c9eZMQjkVPZoI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Feb 2019 19:50:23 -0000

nibanks commented on this pull request.



>  
      // Start a new congestion epoch if the last lost packet
      // is past the end of the previous recovery epoch.
-     CongestionEvent(largest_lost_packet.time_sent)
+     CongestionEvent(newest_lost_packet.time_sent)
+
+     // Collapse congestion window if persistent congestion
+     if (InPersistentCongestion(oldest_lost_packet.time_sent)):

Ok. I'll give it a go.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2365#discussion_r254842942

v2.23.0 | Report a Bug | By Email