IETF Logo Mail Archive

Re: [quicwg/base-drafts] Persistent Congestion Time Threshold (#2365)

ianswett <notifications@github.com> Thu, 07 February 2019 19:49 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B8DDE12D4ED for <quic-issues@ietfa.amsl.com>; Thu, 7 Feb 2019 11:49:08 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.597
X-Spam-Level:
X-Spam-Status: No, score=-1.597 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id o_QrNW-ywnMy for <quic-issues@ietfa.amsl.com>; Thu, 7 Feb 2019 11:49:07 -0800 (PST)
Received: from o1.sgmail.github.com (o1.sgmail.github.com [192.254.114.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BDB2112D4EC for <quic-issues@ietf.org>; Thu, 7 Feb 2019 11:49:06 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=LEA/8K5Aw7XNUZwO5Db8LlS/kN0=; b=t3ymwJCSGWJYelPP LVFdz9YATrKRG/s4eXP+jd3Fwxf97JUPYiYi710qQGg6wemEsnol7k9ynKGHXml5 hLCmKrzNWIquzFsgJAvNAuJ8OnmAB1SCLsDq+PKoA86k2/fnb9h+q4hXT+bGkhi1 U7JcAx70alF2t0LsMXvEwWs88is=
Received: by filter1415p1mdw1.sendgrid.net with SMTP id filter1415p1mdw1-8566-5C5C8BB1-15 2019-02-07 19:49:05.3765326 +0000 UTC m=+168801.807521729
Received: from github-lowworker-b40b5a4.cp1-iad.github.net (unknown [192.30.252.36]) by ismtpd0040p1iad2.sendgrid.net (SG) with ESMTP id Upwi-htESruIlXlfRLDNbg for <quic-issues@ietf.org>; Thu, 07 Feb 2019 19:49:05.397 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-b40b5a4.cp1-iad.github.net (Postfix) with ESMTP id 5FAE73E0081 for <quic-issues@ietf.org>; Thu, 7 Feb 2019 11:49:05 -0800 (PST)
Date: Thu, 07 Feb 2019 19:49:05 +0000
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4aba7b54f82e30ed8659b5fbd6452f76a918299533092cf0000000118744db192a169ce17fab1f6@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2365/review/201289561@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2365@github.com>
References: <quicwg/base-drafts/pull/2365@github.com>
Subject: Re: [quicwg/base-drafts] Persistent Congestion Time Threshold (#2365)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c5c8bb15db7e_78583fd8ddcd45c4422959"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak1UH6/jOxemC6/h0e5waF/l+4c85XJOFQ0lhP EGkWb7eYIJeTgCGaRYCTV0I0u6DSMKvGLMFA/1flso36OhXUo0Dg/9NKt5DBcxX5TITRkIH1LVxh7a NvFz/CqLh1UbvF3pWEQ82rBTwqDsx28VYQHMszk/PLDUYUFyJw5yccuaEQ==
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/t4df-aHVoHa65iBA1jsExBU5Llk>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Feb 2019 19:49:09 -0000

ianswett commented on this pull request.



>  
      // Start a new congestion epoch if the last lost packet
      // is past the end of the previous recovery epoch.
-     CongestionEvent(largest_lost_packet.time_sent)
+     CongestionEvent(newest_lost_packet.time_sent)
+
+     // Collapse congestion window if persistent congestion
+     if (InPersistentCongestion(oldest_lost_packet.time_sent)):

I think how you have it laid out is great and an effort to convert it into text will probably make it less clear.  But I'm not familiar enough with markdown to know how to get the formatting right.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2365#discussion_r254842489

v2.29.0 | Report a Bug | By Email | System Status