Re: [quicwg/base-drafts] Persistent Congestion Time Threshold (#2365)

Nick Banks <notifications@github.com> Mon, 28 January 2019 22:42 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 517FA131254 for <quic-issues@ietfa.amsl.com>; Mon, 28 Jan 2019 14:42:08 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -5.935
X-Spam-Level:
X-Spam-Status: No, score=-5.935 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id W4FW_x36z4PE for <quic-issues@ietfa.amsl.com>; Mon, 28 Jan 2019 14:42:06 -0800 (PST)
Received: from o5.sgmail.github.com (o5.sgmail.github.com [192.254.113.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3298C13124F for <quic-issues@ietf.org>; Mon, 28 Jan 2019 14:42:06 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=MtTA4u0HhPn+Z3uh9ndTjVfikm8=; b=FzgwsaC4MEir2XzF KVBt6rwXDk8Be+xdKocNy8nml85VMrYBRrBuy0FuSTNTX8WIP2Kgn2FSTS0/1Cyr 1ggTA1FEVYlRlteat4OIdMLJ7KNG3K7BoPZRHjMcv5sllpWEqVXgwrAU6UBvcO3/ xzHS3J4JoSNDt7WIa7WvTTWD+QI=
Received: by filter1518p1mdw1.sendgrid.net with SMTP id filter1518p1mdw1-27616-5C4F853C-19 2019-01-28 22:42:04.93736514 +0000 UTC m=+1451.282950835
Received: from github-lowworker-b40b5a4.cp1-iad.github.net (unknown [192.30.252.36]) by ismtpd0029p1iad2.sendgrid.net (SG) with ESMTP id UJzxfnUGQsC5GWzZHdu_2A for <quic-issues@ietf.org>; Mon, 28 Jan 2019 22:42:05.080 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-b40b5a4.cp1-iad.github.net (Postfix) with ESMTP id 11C6A3E0089 for <quic-issues@ietf.org>; Mon, 28 Jan 2019 14:42:05 -0800 (PST)
Date: Mon, 28 Jan 2019 22:42:05 +0000
From: Nick Banks <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abd9adc89659d0a4b2e79da82caffbaf59e6296b9392cf000000011867473d92a169ce17fab1f6@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2365/review/197297569@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2365@github.com>
References: <quicwg/base-drafts/pull/2365@github.com>
Subject: Re: [quicwg/base-drafts] Persistent Congestion Time Threshold (#2365)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c4f853d1051f_1c953f8f452d45c457425c"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: nibanks
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0JfENhbxXjeZE95cZedWbelFZ2a4SIlDu+gm Ea0PXu1TbrJ3fB2wHgKmK0nZ4XwXD4MyqJEhgYag1LG2iL7fDplhX3M/wy52WiuZKqEkFVaxqBvImP 0w87DNwWxyuuitRLnDCDvnN5lZAHuXX5v7UPIfqTBfHhtNeMd01afTl7ArZrc/+YtOME7XJKVCjnvp E=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/pk32Tm5ybGIcMxDpTiuUOgLcMRw>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 28 Jan 2019 22:42:11 -0000

nibanks commented on this pull request.



> @@ -1202,15 +1205,26 @@ Invoked by loss detection from DetectLostPackets when new packets
 are detected lost.
 
 ~~~
+   InPersistentCongestion(oldest_loss_time):
+     return

Sure. I can do that.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2365#discussion_r251625398