Re: [quicwg/base-drafts] Persistent Congestion Time Threshold (#2365)

ianswett <> Wed, 06 February 2019 21:52 UTC

Return-Path: <>
Received: from localhost (localhost []) by (Postfix) with ESMTP id 4CC3512D4F3 for <>; Wed, 6 Feb 2019 13:52:22 -0800 (PST)
X-Virus-Scanned: amavisd-new at
X-Spam-Flag: NO
X-Spam-Score: -11.149
X-Spam-Status: No, score=-11.149 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: (amavisd-new); dkim=pass (1024-bit key)
Received: from ([]) by localhost ( []) (amavisd-new, port 10024) with ESMTP id GoWv2clg8hIB for <>; Wed, 6 Feb 2019 13:52:20 -0800 (PST)
Received: from ( []) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by (Postfix) with ESMTPS id 7A5D3130ECD for <>; Wed, 6 Feb 2019 13:52:20 -0800 (PST)
Date: Wed, 06 Feb 2019 13:52:19 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=pf2014; t=1549489939; bh=ONTdvmZTFyXJclxL/hQgD70VM2W9s0wjWqR0xS4+Bl4=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Z9Q3nvq8u27SvVlrWqI8TK+vOZHzuKFJAr1ztSl54GhJY/lWriL3YpWreeDCXPV4X KWMgQ9z0sZS0C8tFJeNX9cy9h+fHLRBOg1e409OaSHrdwK7Xemy/kcrtd7SngwfBYR jawTevk22L6fP4fBoSxbRhuM8lbY6tOpEOJndwss=
From: ianswett <>
Reply-To: quicwg/base-drafts <>
To: quicwg/base-drafts <>
Cc: Subscribed <>
Message-ID: <quicwg/base-drafts/pull/2365/review/>
In-Reply-To: <quicwg/base-drafts/pull/>
References: <quicwg/base-drafts/pull/>
Subject: Re: [quicwg/base-drafts] Persistent Congestion Time Threshold (#2365)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c5b57135bc69_777e3f8879ed45b839408"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
Archived-At: <>
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <>
List-Unsubscribe: <>, <>
List-Archive: <>
List-Post: <>
List-Help: <>
List-Subscribe: <>, <>
X-List-Received-Date: Wed, 06 Feb 2019 21:52:22 -0000

ianswett commented on this pull request.

      // Start a new congestion epoch if the last lost packet
      // is past the end of the previous recovery epoch.
-     CongestionEvent(largest_lost_packet.time_sent)
+     CongestionEvent(newest_lost_packet.time_sent)
+     // Collapse congestion window if persistent congestion
+     if (InPersistentCongestion(oldest_lost_packet.time_sent)):

I'd like the opinion of @janaiyengar here.  I think this is likely fairly good, but I think passing in newest_lost_time is easy and more correct, given they're easily available in the pseudocode.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub: