IETF Logo Mail Archive

Re: [quicwg/base-drafts] Don't arm the handshake timer if there's no data (#2590)

ianswett <notifications@github.com> Thu, 11 April 2019 17:28 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 16CE612030F for <quic-issues@ietfa.amsl.com>; Thu, 11 Apr 2019 10:28:54 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.597
X-Spam-Level:
X-Spam-Status: No, score=-1.597 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7TKcGNDXgoMK for <quic-issues@ietfa.amsl.com>; Thu, 11 Apr 2019 10:28:52 -0700 (PDT)
Received: from o4.sgmail.github.com (o4.sgmail.github.com [192.254.112.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 81C2C120312 for <quic-issues@ietf.org>; Thu, 11 Apr 2019 10:28:51 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=rgLgBhOu276UlV87IARH5d5xPtU=; b=SqXwE538i97YzABr M0UomR3VG8hyCH3O5EvGe95+CE/WMUQw2rFjAjcF+0e+o6X3L/+3RWjMysPKfQKy 63Ms4IZw5jFlkmjUBtsGGDZXJ8cfK86Qdiy8IJk0wyJWyVIrfb02jZ2AjnK+NLDq HilxGvYveSEBom/2VJTQc2wUyM0=
Received: by filter1613p1mdw1.sendgrid.net with SMTP id filter1613p1mdw1-14201-5CAF794E-35 2019-04-11 17:28:46.860588747 +0000 UTC m=+235085.051123876
Received: from github-lowworker-3c598a3.cp1-iad.github.net (unknown [192.30.252.43]) by ismtpd0036p1iad1.sendgrid.net (SG) with ESMTP id -knrHhWORry-Yoq64bLxpA for <quic-issues@ietf.org>; Thu, 11 Apr 2019 17:28:46.765 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-3c598a3.cp1-iad.github.net (Postfix) with ESMTP id B8DC6A80274 for <quic-issues@ietf.org>; Thu, 11 Apr 2019 10:28:46 -0700 (PDT)
Date: Thu, 11 Apr 2019 17:28:46 +0000
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4aba18ac661f263c446eac50f78a10998229e5eea5a92cebabcabce92a169ce199da23e@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2590/review/225679577@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2590@github.com>
References: <quicwg/base-drafts/pull/2590@github.com>
Subject: Re: [quicwg/base-drafts] Don't arm the handshake timer if there's no data (#2590)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5caf794eb6042_38ea3fbe370d45b45548f8"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak2+Jaab3O5iXa5GtuI/wR97sskkfkf7T1wEqL s/HCL81X6Fc1uAt80jIYQ6u1R8D0QbMVnHD62Li8t2mCHjw+hkCx6Hds+rVZ8LMG4cXZjQ1NX8iq36 N+H8HsPTrnIyvYlSK/ddCLG42xI6IdfyXt9u+X3KVGzsVAs603xOaJu2XHovYkOoeAc8badAO554zJ U=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/MDN45SKIJZCugfEzK2RP-YoE2CA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Apr 2019 17:28:54 -0000

ianswett commented on this pull request.



> @@ -1151,7 +1158,8 @@ OnLossDetectionTimeout():
     DetectLostPackets(pn_space)
   // Retransmit crypto data if no packets were lost
   // and there are still crypto packets in flight.
-  else if (crypto packets are in flight):
+  else if (crypto packets are in flight &&
+           crypto data to send):

Crypto packets could be in flight because of a timer based retransmission, but the original was ACked.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2590#discussion_r274543618

v2.23.0 | Report a Bug | By Email