Re: [quicwg/base-drafts] Don't arm the handshake timer if there's no data (#2590)
Jana Iyengar <notifications@github.com> Thu, 11 April 2019 02:40 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 886A0120158 for <quic-issues@ietfa.amsl.com>; Wed, 10 Apr 2019 19:40:19 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.001
X-Spam-Level:
X-Spam-Status: No, score=-8.001 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ITkaX5BN8XyD for <quic-issues@ietfa.amsl.com>; Wed, 10 Apr 2019 19:40:17 -0700 (PDT)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6133412003E for <quic-issues@ietf.org>; Wed, 10 Apr 2019 19:40:17 -0700 (PDT)
Date: Wed, 10 Apr 2019 19:40:16 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1554950416; bh=gev8MT/QvTgD/+S9kLZZGngjmKUEKIN2lazL0QEYKYA=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=kLJfoegnCtvB+rfRLQxy88L/bdDFNZxiPSB71fMu+8rTAHRNhTgDQ8oMLTCfEO/mO 7Qb4zlynAJcSPH/NwgNergm0qK+/E1rNjwhYzOEiE/3L5Z9tP3q4yZ/qo4Xm7sLA1I epbOWTnYBv3cO3ZmXWPnebz4zbsdVYojsxsxFJGs=
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abe0d88a7f63eea58f8e096eb78d0a4bf80ff7319292cebabbdb9092a169ce199da23e@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2590/review/225302634@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2590@github.com>
References: <quicwg/base-drafts/pull/2590@github.com>
Subject: Re: [quicwg/base-drafts] Don't arm the handshake timer if there's no data (#2590)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5caea9108215a_2aee3fa2a76d45b43206e6"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/ruJOJ2tW3ZkdxvxEDUf31lJaPSs>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Apr 2019 02:40:19 -0000
janaiyengar commented on this pull request. > @@ -458,17 +463,18 @@ sent, then no alarm should be armed until data has been received from the client. Because the server could be blocked until more packets are received, the client -MUST start the crypto retransmission timer even if there is no unacknowledged -CRYPTO data. If the timer expires and the client has no CRYPTO data to -retransmit and does not have Handshake keys, it SHOULD send an Initial packet in -a UDP datagram of at least 1200 bytes. If the client has Handshake keys, it -SHOULD send a Handshake packet. - -On each consecutive expiration of the crypto timer without receiving an -acknowledgement for a new packet, the sender SHOULD double the crypto -retransmission timeout and set a timer for this period. +MUST ensure that the crypto retransmission timer is set if there is +unacknowledged crypto data or if the client does not yet have 1-RTT keys. +If the crypto retransmission timer expires before the client has 1-RTT keys, +it is possible that the client may not have any crypto data to retransmit. +The client MUST send a new packet to allow the server to continue sending ```suggestion However, the client MUST send a new packet, containing only PING or PADDDING frames if necessary, to allow the server to continue sending ``` > -When a crypto packet is sent, the sender MUST set a timer for the crypto -timeout period. This timer MUST be updated when a new crypto packet is sent. -Upon timeout, the sender MUST retransmit all unacknowledged CRYPTO data if -possible. +When a crypto packet is sent, the sender MUST set a timer for twice the smoothed +RTT. This timer MUST be updated when a new crypto packet is sent and when +an acknowledgement is received which computes a new RTT sample. Upon timeout, +the sender MUST retransmit all unacknowledged CRYPTO data if possible. The +sender MUST NOT declare in flight crypto packets as lost when the crypto timer ```suggestion sender MUST NOT declare in-flight crypto packets as lost when the crypto timer ``` > @@ -1151,7 +1158,8 @@ OnLossDetectionTimeout(): DetectLostPackets(pn_space) // Retransmit crypto data if no packets were lost // and there are still crypto packets in flight. - else if (crypto packets are in flight): + else if (crypto packets are in flight && + crypto data to send): I still don't get this. If crypto packets are in flight, doesn't that mean there is unacked crypto data to send? Why is this second predicate useful? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/2590#pullrequestreview-225302634
- [quicwg/base-drafts] Don't arm the handshake time… ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … Marten Seemann
- Re: [quicwg/base-drafts] Don't arm the handshake … martinduke
- Re: [quicwg/base-drafts] Don't arm the handshake … martinduke
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … martinduke
- Re: [quicwg/base-drafts] Don't arm the handshake … Marten Seemann
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … martinduke
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … martinduke
- Re: [quicwg/base-drafts] Don't arm the handshake … martinduke
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … martinduke
- Re: [quicwg/base-drafts] Don't arm the handshake … Marten Seemann
- Re: [quicwg/base-drafts] Don't arm the handshake … martinduke
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … Jana Iyengar
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … Jana Iyengar
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … Jana Iyengar
- Re: [quicwg/base-drafts] Don't arm the handshake … Jana Iyengar
- Re: [quicwg/base-drafts] Don't arm the handshake … Benjamin Saunders
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … Jana Iyengar
- Re: [quicwg/base-drafts] Don't arm the handshake … Jana Iyengar