Re: [quicwg/base-drafts] Clarify text around preferred address (#3589)

ianswett <> Tue, 21 April 2020 02:32 UTC

Return-Path: <>
Received: from localhost (localhost []) by (Postfix) with ESMTP id 8F7393A1421 for <>; Mon, 20 Apr 2020 19:32:38 -0700 (PDT)
X-Virus-Scanned: amavisd-new at
X-Spam-Flag: NO
X-Spam-Score: -0.474
X-Spam-Status: No, score=-0.474 tagged_above=-999 required=5 tests=[DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_28=0.726, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: (amavisd-new); dkim=pass (1024-bit key)
Received: from ([]) by localhost ( []) (amavisd-new, port 10024) with ESMTP id tR_4PvGUGkMY for <>; Mon, 20 Apr 2020 19:32:37 -0700 (PDT)
Received: from ( []) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by (Postfix) with ESMTPS id D14CF3A1110 for <>; Mon, 20 Apr 2020 19:32:36 -0700 (PDT)
Received: from ( []) by (Postfix) with ESMTP id 962F9C60E22 for <>; Mon, 20 Apr 2020 19:32:35 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=pf2014; t=1587436355; bh=JijVLgz4l67o4fciw/U7h8xNhy6OQX8uaN7GuXJBQ/w=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=KFSBOLMq7sh3X06DCe17+IMsR7E1+BKYOalcBcfE6bOYhjsdt9qWaeQN3uuFoXA1s 2tutpI+0JqmqAVBrRWa3RPWaRmne+95B4MIq68TpGHQrLpsBNdUwr11hFSj1pB6KLo nXn7nJZUpq38RCbOSQ5FIiT1vAYy+hRyy0s2XPcE=
Date: Mon, 20 Apr 2020 19:32:35 -0700
From: ianswett <>
Reply-To: quicwg/base-drafts <>
To: quicwg/base-drafts <>
Cc: Subscribed <>
Message-ID: <quicwg/base-drafts/pull/3589/review/>
In-Reply-To: <quicwg/base-drafts/pull/>
References: <quicwg/base-drafts/pull/>
Subject: Re: [quicwg/base-drafts] Clarify text around preferred address (#3589)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e9e5b43872c1_45283f9e3d8cd9601009bb"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
Archived-At: <>
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <>
List-Unsubscribe: <>, <>
List-Archive: <>
List-Post: <>
List-Help: <>
List-Subscribe: <>, <>
X-List-Received-Date: Tue, 21 Apr 2020 02:32:39 -0000

@ianswett approved this pull request.

Some small nits, but this looks good.

> +Similarly, an endpoint MUST NOT reuse a connection ID when sending to more than
+one destination address, for example when responding to a change in the address
+of a peer if the packet with the new peer address uses an active connection ID
+that has not been previously used by the peer.

Is rationale useful here?   ie "as this indicates the peer did not intentionally change its address."?

> @@ -5610,7 +5619,7 @@ IDs, the endpoint MAY treat that receipt as a connection error of type
 The Retire Prior To field counts connection IDs established during connection
-setup and the preferred_address transport parameter (see {{retiring-cids}}). The
+setup and the preferred_address transport parameter (see {{retire-cid}}). The

I thought parens were fine?  Personally, I prefer parens, so I'm curious why prefer semicolons?

I think they're used quite widely, so if you want to consistently move to semicolons, I'd suggest a single cleanup PR to switch everything over.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub: