Re: [quicwg/base-drafts] Fix to ECN section regarding validation (#2113)

[Martin Thomson <[e-mail]>]

martinthomson commented on this pull request.



> @@ -3018,11 +3018,23 @@ elements on the network path, an endpoint verifies the following when an ACK
 frame is received:

I think that we need a little restructuring here.

> To reduce the risk of bad ECN markings affecting the operation of an endpoint, an endpoint verifies the counts it receives when it receives new acknowledgements:
> 
> * \[bullets]
>
> This validation is only performed if the ACK frame increases the largest received packet number.  Reordered acknowledgments could have lower counter values and might not be successfully validated as a result.
>
> These counts might be inflated if acknowledgments are never received for packets that were successfully delivered.  If validation succeeds, an endpoint MUST increase its expected counter values to those it receives.

Note that I almost didn't use MUST on that last clause, because there is no interop loss from doing that; it only means that validation is less likely to catch bad markings.

I also removed the "If the sender does not have state to determine if a packet is newly acknowledged..."  Such a packet - such as a packet that is declared lost - will never be considered to be newly acknowledged.

Would you like this as a PR?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2113#pullrequestreview-184517682