IETF Logo Mail Archive

Re: [quicwg/base-drafts] Fix to ECN section regarding validation (#2113)

Magnus Westerlund <notifications@github.com> Thu, 13 December 2018 07:56 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C341212875B for <quic-issues@ietfa.amsl.com>; Wed, 12 Dec 2018 23:56:24 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.056
X-Spam-Level:
X-Spam-Status: No, score=-3.056 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Fteuez3l2W_Y for <quic-issues@ietfa.amsl.com>; Wed, 12 Dec 2018 23:56:23 -0800 (PST)
Received: from o3.sgmail.github.com (o3.sgmail.github.com [192.254.112.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D6629126CB6 for <quic-issues@ietf.org>; Wed, 12 Dec 2018 23:56:22 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=KX6OjqAP7D4BozoQmbFTtdbzO/M=; b=ATksA+Clwl+LJ6An 9Twk4sXT94T/Y//c1p+Wvb3wZwMZyN+GfIRQdh3HjW5a1Kejl+soiOoCeyTIcra1 ymb3YPpb4kYL0nQBy6Za42jAoBOZrp44fcjgIuBQahUs7VJidKD1K71QXAchLM0g xk9ZCg8q/m9T2mrDog5cfojhUoU=
Received: by filter1154p1las1.sendgrid.net with SMTP id filter1154p1las1-30620-5C1210A5-15 2018-12-13 07:56:21.642744503 +0000 UTC m=+101626.447341932
Received: from github-lowworker-97d0962.cp1-iad.github.net (unknown [192.30.252.41]) by ismtpd0010p1iad2.sendgrid.net (SG) with ESMTP id TcNtqEn0QxWqC6ZBu4D0Mg for <quic-issues@ietf.org>; Thu, 13 Dec 2018 07:56:21.543 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-97d0962.cp1-iad.github.net (Postfix) with ESMTP id 7FEFD80099 for <quic-issues@ietf.org>; Wed, 12 Dec 2018 23:56:21 -0800 (PST)
Date: Thu, 13 Dec 2018 07:56:21 +0000
From: Magnus Westerlund <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab2164d1a4fe96e6de51640567f2a2ace53081950a92cf000000011829d2a592a169ce173be661@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2113/review/184535854@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2113@github.com>
References: <quicwg/base-drafts/pull/2113@github.com>
Subject: Re: [quicwg/base-drafts] Fix to ECN section regarding validation (#2113)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c1210a57e93a_467b3fe97bcd45c075457e"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: gloinul
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak2n2pfUI/Hm32FuU25WZzpMceElJWQFXXQaNL zzdt8jVZRptrKEu21vQSvSgRz4AIM1+IKpFFfUj2mgQRfIl8Q/m4OMB/YqnV64uIJm2Oh3zXvYCjCL 1rCw9idZFO8tdSvIfljsFjQwIWy9d17P17XV4Kn+t8bY+SDYIin5oYZ85+Jf5zEA03XrNqwBskibYi g=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/yW-cUl-w6TlWqdr9VRgKgOa_O00>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Dec 2018 07:56:25 -0000

gloinul commented on this pull request.



> @@ -3018,11 +3018,23 @@ elements on the network path, an endpoint verifies the following when an ACK
 frame is received:

I think the restructuring is fine. On a high level I agree with your removal of the if you are missing state. However, considering some of the discussion on the quicdev slack I do wonder if something along those lines needs to be included to ensure that people are not interpreting this as requiring one to maintain state further into history than what one otherwise would. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2113#discussion_r241300008

v2.23.0 | Report a Bug | By Email