IETF Logo Mail Archive

Re: [quicwg/base-drafts] Fix to ECN section regarding validation (#2113)

Martin Thomson <notifications@github.com> Thu, 13 December 2018 23:21 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 15F8D127AC2 for <quic-issues@ietfa.amsl.com>; Thu, 13 Dec 2018 15:21:31 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.056
X-Spam-Level:
X-Spam-Status: No, score=-8.056 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Z_tTLrpqiwSf for <quic-issues@ietfa.amsl.com>; Thu, 13 Dec 2018 15:21:29 -0800 (PST)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1BC97130EBA for <quic-issues@ietf.org>; Thu, 13 Dec 2018 15:21:28 -0800 (PST)
Date: Thu, 13 Dec 2018 15:21:27 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1544743287; bh=UCC8iUZialklkiCGfe7pnkbdh2ahzR4xd2U4mCArYCU=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=nDbCLgFcPu61/PSOV8YOJK7UL6ySblhyXk//J+Qf5BKDT+GRN4bSdWT689F/X4bab K22WLLi18egUq/jwz89xHQYL5UvdHb5ReoJMZ9Vu3hORchwbl0fujTWRbsvCEMDrSN LkCdug29Eg/9nx7SEiyO7xZim7L/851rO8Bor4SY=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abd796347b447089237ac00ee593e3c5baccaf9cfe92cf00000001182aab7792a169ce173be661@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2113/review/184913851@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2113@github.com>
References: <quicwg/base-drafts/pull/2113@github.com>
Subject: Re: [quicwg/base-drafts] Fix to ECN section regarding validation (#2113)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c12e97728715_7ef53f8b874d45c02677f"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/qt-EPamwauZsbyEFtcRUs2DAitM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Dec 2018 23:21:31 -0000

martinthomson commented on this pull request.



> @@ -3018,11 +3018,23 @@ elements on the network path, an endpoint verifies the following when an ACK
 frame is received:

Thanks for that.

The pseudocode in the recovery draft drops packets from the "in flight" structure when they are declared lost and only treats packets as "newly acknowledged" if they are in that structure.  I think that makes it clear enough.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2113#discussion_r241597873

v2.23.0 | Report a Bug | By Email