IETF Logo Mail Archive

[quicwg/base-drafts] Fix to ECN section regarding validation (#2113)

Magnus Westerlund <notifications@github.com> Tue, 11 December 2018 14:53 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BC512127333 for <quic-issues@ietfa.amsl.com>; Tue, 11 Dec 2018 06:53:51 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.46
X-Spam-Level:
X-Spam-Status: No, score=-4.46 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YM4LwW2CHwMV for <quic-issues@ietfa.amsl.com>; Tue, 11 Dec 2018 06:53:50 -0800 (PST)
Received: from o7.sgmail.github.com (o7.sgmail.github.com [167.89.101.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EA8D7124408 for <quic-issues@ietf.org>; Tue, 11 Dec 2018 06:53:49 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=3c/YMUPnUK3js6HThURgXLnMO/g=; b=A2R8iMUD3l9+f1Jt JRAbyYIP5k1PaMKNXyRyjypc4dtlDS9uXru/Vq35X7NPpWnGdefrdJQw+pKNEmIX UvzhjAdvDshoZDDAOf+azSPxjYiCBL6PZj4wmqUlARumPwpBDJtY6n1io8IW2Q/0 ZPcvZGO3GwarZeABjpL3TxUGbu0=
Received: by filter1109p1las1.sendgrid.net with SMTP id filter1109p1las1-3459-5C0FCF7D-2 2018-12-11 14:53:49.10254108 +0000 UTC m=+57433.060278301
Received: from github-lowworker-dc5ea3e.cp1-iad.github.net (unknown [192.30.252.45]) by ismtpd0026p1iad2.sendgrid.net (SG) with ESMTP id 7Tzt47EwTCm9hG2eQF3rww for <quic-issues@ietf.org>; Tue, 11 Dec 2018 14:53:48.970 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-dc5ea3e.cp1-iad.github.net (Postfix) with ESMTP id F053F260C7B for <quic-issues@ietf.org>; Tue, 11 Dec 2018 06:53:48 -0800 (PST)
Date: Tue, 11 Dec 2018 14:53:49 +0000
From: Magnus Westerlund <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abf22cb2cea4a4d5449fa7a54fec3661a76a22504792cf000000011827917c92a169ce173be661@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2113@github.com>
Subject: [quicwg/base-drafts] Fix to ECN section regarding validation (#2113)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c0fcf7ceddd2_713b3ff7e78d45b81103cf"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: gloinul
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak11ESego08ktTM/nbjySPbfdPokSxNmTAu0LG ksuP+53JQuFf/SHM6p2zmWgL6mh9E8m0Q9DdzkpzLmHHWw+W/q33SxBoM4A6/OI70cl4CrNkci8PZf 0uZA98LmxpWZ5twY3WLhDNJE4QKkEQlqfrb/ZRhtBfiegK1TlTE3u9PCFUFRruGe24K0NkL0b+7/dl w=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/isVOkJefNx2s9bD4ixxK-LoDPc8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Dec 2018 14:53:52 -0000

An issue with validation was identified. The first bullet of validation is intended to check so that the ECT code point (0 or 1) are not changed to the other. However, when an ACK includes new CE marks the comparison must deduct those CE marks to not wrongly report a mismatch. 

Also fixed a sentence indicating that is unclear about what is dropped. ECN field value of not-ect could rarely result in that the IP packet to be dropped. 
You can view, comment on, or merge this pull request online at:

  https://github.com/quicwg/base-drafts/pull/2113

-- Commit Summary --

  * Addressing issue that CE marks was not handled in per ECT type check.
  * Fixing one unclear sentence.

-- File Changes --

    M draft-ietf-quic-transport.md (6)

-- Patch Links --

https://github.com/quicwg/base-drafts/pull/2113.patch
https://github.com/quicwg/base-drafts/pull/2113.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2113

v2.23.0 | Report a Bug | By Email