Re: [quicwg/base-drafts] Request to Retire Locally Issued CIDs (#2769)
Martin Thomson <notifications@github.com> Wed, 05 June 2019 06:13 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D6565120224 for <quic-issues@ietfa.amsl.com>; Tue, 4 Jun 2019 23:13:20 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.424
X-Spam-Level:
X-Spam-Status: No, score=-8.424 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-0.415, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nn6gZWSRf6W8 for <quic-issues@ietfa.amsl.com>; Tue, 4 Jun 2019 23:13:19 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1003112003E for <quic-issues@ietf.org>; Tue, 4 Jun 2019 23:13:19 -0700 (PDT)
Date: Tue, 04 Jun 2019 23:13:17 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1559715197; bh=ZNag8pXESK8txxjecDqqLvU0vjl0U5HeWukn1D4mmdY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=phxCjB5l9cCyr2upnaTRs1kJyDaT6OMtOkqioStKr+viw2nDetCNvu1OqFk5Ktml3 uOiPRp+KV7eX63deqTaTsODJqriH8ff4jwDcPcok6ajGNfACloR2TJKeQSC0V0RRAv PgFYSqsNthvfnUnJtO6qOBue/rA4MU141z3VPkzE=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7TTEYX745VGO5RS6V3ASH73EVBNHHBV45H2U@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2769/review/245819379@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2769@github.com>
References: <quicwg/base-drafts/pull/2769@github.com>
Subject: Re: [quicwg/base-drafts] Request to Retire Locally Issued CIDs (#2769)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cf75d7dd2867_18c73fa65a4cd96c228091"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/KFiS_vOo8tQOSyxi-lxuafHOeNI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Jun 2019 06:13:21 -0000
martinthomson commented on this pull request. > @@ -994,6 +994,14 @@ packets sent from only one local address. An endpoint that migrates away from a local address SHOULD retire all connection IDs used on that address once it no longer plans to use that address. +The endpoint can explicitly request its peer to retire connection IDs by sending +a NEW_CONNECTION_ID frame that contains a Retire Prior To field. The peer is +required to retire these connection IDs in a timely manner. On receipt of the +acknowledgement for the packet that contained the NEW_CONNECTION_ID frame, the +endpoint may start a 3 PTO timer, which on expiring may close the connection MAY and MAY here > @@ -4984,6 +4994,12 @@ Sequence Number: : The sequence number assigned to the connection ID by the sender. See {{issue-cid}}. +Retire Prior To: + +: A variable-length integer specifying the limit, for which all connection IDs + assigned to the receiver that have a sequence number less this value should be + retired. See {{retiring-cids}}. This field is only present for type=0x19. This doesn't say anything about what to do with the connection ID that is negotiated during the handshake, and the one attached to a server preferred address. > @@ -5018,10 +5034,16 @@ sequence number, or if a sequence number is used for different connection IDs, the endpoint MAY treat that receipt as a connection error of type PROTOCOL_VIOLATION. +If the Retire Prior To field is present it is a request for the peer to +immediately retire all connection IDs with a sequence number less than the +specified value. For more information see {{retiring-cids}}. This field +should only ever increase, though reordering and retransmission of older packets There's lots of vague 2119-lite language here. The language on flow control can be used here: > A receiver cannot renege on an advertisement however. That is, once a receiver advertises an offset, it MAY advertise a smaller offset, but this has no effect. > [...] > A sender MUST ignore any MAX_STREAM_DATA or MAX_DATA frames that do not increase flow control limits. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/2769#pullrequestreview-245819379
- Re: [quicwg/base-drafts] Request to Retire Locall… MikkelFJ
- [quicwg/base-drafts] Request to Retire Locally Is… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… MikkelFJ
- Re: [quicwg/base-drafts] Request to Retire Locall… MikkelFJ
- Re: [quicwg/base-drafts] Request to Retire Locall… MikkelFJ
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… MikkelFJ
- Re: [quicwg/base-drafts] Request to Retire Locall… ianswett
- Re: [quicwg/base-drafts] Request to Retire Locall… Martin Thomson
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… Kazuho Oku
- Re: [quicwg/base-drafts] Request to Retire Locall… Martin Thomson
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… ianswett
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… Eric Kinnear
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… Kazuho Oku
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… Marten Seemann
- Re: [quicwg/base-drafts] Request to Retire Locall… Kazuho Oku
- Re: [quicwg/base-drafts] Request to Retire Locall… Marten Seemann
- Re: [quicwg/base-drafts] Request to Retire Locall… MikkelFJ
- Re: [quicwg/base-drafts] Request to Retire Locall… Mike Bishop
- Re: [quicwg/base-drafts] Request to Retire Locall… Mike Bishop
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… Mike Bishop
- Re: [quicwg/base-drafts] Request to Retire Locall… Eric Kinnear
- Re: [quicwg/base-drafts] Request to Retire Locall… Mike Bishop
- Re: [quicwg/base-drafts] Request to Retire Locall… MikkelFJ
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… Mike Bishop
- Re: [quicwg/base-drafts] Request to Retire Locall… David Schinazi
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… Kazuho Oku
- Re: [quicwg/base-drafts] Request to Retire Locall… Kazuho Oku
- Re: [quicwg/base-drafts] Request to Retire Locall… MikkelFJ
- Re: [quicwg/base-drafts] Request to Retire Locall… David Schinazi
- Re: [quicwg/base-drafts] Request to Retire Locall… Marten Seemann
- Re: [quicwg/base-drafts] Request to Retire Locall… MikkelFJ
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… David Schinazi
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… MikkelFJ
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… MikkelFJ
- Re: [quicwg/base-drafts] Request to Retire Locall… Mike Bishop
- Re: [quicwg/base-drafts] Request to Retire Locall… Mike Bishop
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… ianswett
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… Martin Thomson
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… David Schinazi
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… David Schinazi
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… ianswett
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… Eric Kinnear
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… ianswett
- Re: [quicwg/base-drafts] Request to Retire Locall… Eric Kinnear
- Re: [quicwg/base-drafts] Request to Retire Locall… Eric Kinnear
- Re: [quicwg/base-drafts] Request to Retire Locall… Mike Bishop
- Re: [quicwg/base-drafts] Request to Retire Locall… Eric Kinnear
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… ianswett
- Re: [quicwg/base-drafts] Request to Retire Locall… Eric Kinnear
- Re: [quicwg/base-drafts] Request to Retire Locall… Marten Seemann
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… Mike Bishop
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… Eric Kinnear
- Re: [quicwg/base-drafts] Request to Retire Locall… Martin Thomson
- Re: [quicwg/base-drafts] Request to Retire Locall… Igor Lubashev
- Re: [quicwg/base-drafts] Request to Retire Locall… Martin Thomson
- Re: [quicwg/base-drafts] Request to Retire Locall… Igor Lubashev
- Re: [quicwg/base-drafts] Request to Retire Locall… Nick Banks
- Re: [quicwg/base-drafts] Request to Retire Locall… Martin Thomson