Re: [bess] MIBDoc review of draft-ietf-bess-l2l3-vpn-mcast-mib-07

Hiroshi Tsunoda <tsuno@m.ieice.org> Wed, 21 June 2017 17:35 UTC

Return-Path: <dr.h.t@ieee.org>
X-Original-To: bess@ietfa.amsl.com
Delivered-To: bess@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 57C9A120725 for <bess@ietfa.amsl.com>; Wed, 21 Jun 2017 10:35:50 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.599
X-Spam-Level:
X-Spam-Status: No, score=-2.599 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=ieee-org.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3G0bMfivezYn for <bess@ietfa.amsl.com>; Wed, 21 Jun 2017 10:35:46 -0700 (PDT)
Received: from mail-qk0-x22e.google.com (mail-qk0-x22e.google.com [IPv6:2607:f8b0:400d:c09::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 860FC128C83 for <bess@ietf.org>; Wed, 21 Jun 2017 10:35:46 -0700 (PDT)
Received: by mail-qk0-x22e.google.com with SMTP id d14so88324647qkb.1 for <bess@ietf.org>; Wed, 21 Jun 2017 10:35:46 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ieee-org.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=RsZ9ICNHzfQ9ZuMvFJBmUbcvTc8OiW6HURybyXMKDLI=; b=qWTnovLI/Iuj+ANREE3otKNn84vKfaTeSvF3R3bn653+hfzDti2OjXfrLcBdOfFQJQ n4KvxFLfprfKmgOc7II1hYmEIbCYzeGPO2TlfilsJJtpBuRixj0dSLM4H7j9begvnwcB wk3uK+mZgXumwtnGU+oN2SSHopo1ledaDG0e/2s+mIL7rnTQw3SH6Ud0NpZE4/T+fpIz 8mKNwO/v9wVho0mIJt2wahCQjYPc+HArT6RdD+Vt4OdNbXNUY5u9XoG/RDW7bf4/Bj+e Db55m/h3o256GZeutvqDmnASqTujkJyELVL1SrOQQktgCqAzgu0ZE1UA6yOQpkrljFXo uDUw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=RsZ9ICNHzfQ9ZuMvFJBmUbcvTc8OiW6HURybyXMKDLI=; b=GqaWK/Tb/XMWiyhTaGnk5p2LwaEdx/KefEnvOFBEdp4RtMq370H/OSUswMkCewq/sb 8l3/5MJtbL4V9TUGSNiqZfVW5IGH6LpEwuh3HexJczQWE2tGMG6umHplA2e74761L58a nWtIgy962Lcuwvy1RX0fGo/PZdybmwXXXV8UCrriFDrSC6CsFzFHtBbt+6wMWvYc57Fd uQB7oonMjgHD5YfmS+i7ptuZbEqt+Mm1UffpiJOwhGKHhJYDduJsMfN/IcOGdD4k3v17 bKlZzwdyEgTWQmOY6YKhbqmS4s2J47Fr4IBIMs7OBxG7L1WW86mkWuIMHrZr2vPfrU4o hGnQ==
X-Gm-Message-State: AKS2vOyOTcctOCi6rOQmhzYn7LxdzcYiD2jNx5KR9FEriHwFTNb9ARwo jAi/GWzTHnQ5eQ7l0ZiNhVRgIRpsJ/dR
X-Received: by 10.55.15.9 with SMTP id z9mr39587024qkg.195.1498066545630; Wed, 21 Jun 2017 10:35:45 -0700 (PDT)
MIME-Version: 1.0
Sender: dr.h.t@ieee.org
Received: by 10.140.101.229 with HTTP; Wed, 21 Jun 2017 10:35:05 -0700 (PDT)
In-Reply-To: <3bb4da95-ce97-385d-ae59-963d8c6f3db0@cysols.com>
References: <56E7D219.7000902@orange.com> <BLUPR0501MB17151A695785D4D8DD485633D4690@BLUPR0501MB1715.namprd05.prod.outlook.com> <b4249e61-0a11-2ce1-c846-67096858fa2c@cysols.com> <BLUPR0501MB1715A3B288A27A39E99203B8D4490@BLUPR0501MB1715.namprd05.prod.outlook.com> <c757a323-24a7-2696-657e-88f8e15e8a36@cysols.com> <CAPbjwkyFeX-S=sJwNMX-fgWThnMMiu_nF8xvcMow_BgJSfwsSQ@mail.gmail.com> <5e663cf0-1418-c410-bcf8-b235ee73fc29@cysols.com> <CAPbjwkyN0yLkpOXWt8D2-Niw7BCoujF+8JLjrPwgWobF03hZ7g@mail.gmail.com> <6f89f1f2-31e9-bf4a-05e9-1bb6e02f339e@cysols.com> <CAPbjwkyEnCGZEsGKjHozWmg-X-P3483=205BBGV9+DxbfJsDmQ@mail.gmail.com> <03f83a27-e397-818d-65e7-27f95cd6e6e0@cysols.com> <CAPbjwkzkKOULh98QBmbArFWXv=o_pyd7J82u7_GvwkWELdY0Pg@mail.gmail.com> <8f9aaac8-f44d-4844-d376-9c37bd7a81e0@cysols.com> <1848f053-9a5e-2f52-09b4-ce0e1688b557@cysols.com> <CAPbjwkzgORotsvYPWF2fqC7icJFXi5z10D1UHDTtYp1wojxw0Q@mail.gmail.com> <CAPbjwkw=zTUB+RL2MN7g2CeW07Xc6o39g6sf6ZpKap1+49ENiw@mail.gmail.com> <3bb4da95-ce97-385d-ae59-963d8c6f3db0@cysols.com>
From: Hiroshi Tsunoda <tsuno@m.ieice.org>
Date: Wed, 21 Jun 2017 19:35:05 +0200
X-Google-Sender-Auth: ktIZQCqXEuWgdXu8_UaHNInNOhs
Message-ID: <CAPbjwky5ixKXn60bdqD=9mW=ut4rANiQ7AKMCjZw8UTEzxfrqw@mail.gmail.com>
To: Glenn Mansfield Keeni <glenn@cysols.com>
Cc: Mach Chen <mach.chen@huawei.com>, "mib-doctors@ietf.org" <mib-doctors@ietf.org>, "Jeffrey (Zhaohui) Zhang" <zzhang@juniper.net>, "EXT - thomas.morin@orange.com" <thomas.morin@orange.com>, Martin Vigoureux <martin.vigoureux@nokia.com>, "bess@ietf.org" <bess@ietf.org>
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://mailarchive.ietf.org/arch/msg/bess/Tt1-zYBS1lpL2E_5OG5mTH30sCs>
Subject: Re: [bess] MIBDoc review of draft-ietf-bess-l2l3-vpn-mcast-mib-07
X-BeenThere: bess@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: BGP-Enabled ServiceS working group discussion list <bess.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bess>, <mailto:bess-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bess/>
List-Post: <mailto:bess@ietf.org>
List-Help: <mailto:bess-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bess>, <mailto:bess-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Jun 2017 17:35:50 -0000

Dear Glenn,

Thank you for your comments. I posted a new revision (-09) as follows.

URL:
https://www.ietf.org/internet-drafts/draft-ietf-bess-l2l3-vpn-mcast-mib-09.txt
Htmlized:
https://tools.ietf.org/html/draft-ietf-bess-l2l3-vpn-mcast-mib-09
Htmlized:
https://datatracker.ietf.org/doc/html/draft-ietf-bess-l2l3-vpn-mcast-mib-09
Diff:
https://www.ietf.org/rfcdiff?url2=draft-ietf-bess-l2l3-vpn-mcast-mib-09

In the new revision, all of your comments are addressed and
the following additional changes are made.

-   Update the definition and description of L2L3VpnMcastProviderTunnelType
    Describe the enumerated values and the corresponding
    tunnel type.
    I added new valule, transportTunnel (8) defined in [RFC7524].

 - Add some description related to transportTunnel (8)
   into the defi L2L3VpnMcastProviderTunnelId

 - Update the description of l2L3VpnMcastPmsiTunnelAttributeFlags
   according to [RFC7902]

 -  Added a new object, l2L3VpnMcastPmsiTunnelAttributeAddlFlags.
    This is defined in [RFC7902]

I also removed some paragraph from 1.1 Terminology section,
because those seem verbose.

Please see some other notes below.

2017-06-05 12:24 GMT+02:00 Glenn Mansfield Keeni <glenn@cysols.com>om>:
> 1. The explanations for the size of the identifiers for each tunneling
>    technology in TC L2L3VpnMcastProviderTunnelId
>    is nicely done. These are aligned with definitions in rfc6514.
>    In
>            noTunnelId         (0), -- No tunnel information
>    is there a specific reason to name it 'noTunnelId' instead of
>    'noTunnelInfo'.

Fixed.

> 2. The TCs
>        L2L3VpnMcastProviderTunnelPointerType, and
>        L2L3VpnMcastProviderTunnelPointer
>    Are probably not required. The value of the RowPointer [rfc2579]
>    object is ' the name of the instance of the first
>                accessible columnar object in the conceptual row'
>    So the pointer will explicitly contain the name of the table.
>    An auxilliary type object to indicate the table name is not
>    necessary.
>   [This is an oversight on my part. I should have noticed this earlier.]

These TCs were removed and related descriptions in other parts
in the document were updated.

> Other Editorials:
> P-2. Sec-1.
> 1.   para-1 makes tedious reading. Could this be improved?
>
> 2.       "Border Gateway Protocol/ MultiProtocol Label Switching (BGP/MPLS)"
>      The usage of the '/' here is unclear.

Updated.
In the new revision, BGP/MPLS VPN is explained in para-1, and
multicast support in BGP/MPLS Layer 2 and Layer 3 is explained in para-2
separately.

> 3.       "and L3 VPNs.  Therefore, TCs and MOs defined"
>      The context of the 'Therefore' is not clear.

Fixed. I removed the related sentence because it seemed not
required already.

> 4.       "The are two type"
>      Probably s/The/There/ ?

Fixed. Thank you for pointing it out.

-- tsuno