Re: [dane] Start of WGLC for draft-ietf-dane-openpgpkey - *please* review.

Paul Wouters <paul@nohats.ca> Mon, 09 March 2015 20:01 UTC

Return-Path: <paul@nohats.ca>
X-Original-To: dane@ietfa.amsl.com
Delivered-To: dane@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 977871AC400 for <dane@ietfa.amsl.com>; Mon, 9 Mar 2015 13:01:22 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.01
X-Spam-Level:
X-Spam-Status: No, score=-2.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, T_RP_MATCHES_RCVD=-0.01] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 22Iu4m74x1pR for <dane@ietfa.amsl.com>; Mon, 9 Mar 2015 13:01:21 -0700 (PDT)
Received: from mx.nohats.ca (mx.nohats.ca [193.110.157.68]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9DEC91AC3EE for <DANE@ietf.org>; Mon, 9 Mar 2015 13:01:18 -0700 (PDT)
Received: from localhost (localhost [IPv6:::1]) by mx.nohats.ca (Postfix) with ESMTP id 3l19RG6s4zz47H; Mon, 9 Mar 2015 21:01:14 +0100 (CET)
Authentication-Results: mx.nohats.ca; dkim=pass reason="1024-bit key; unprotected key" header.d=nohats.ca header.i=@nohats.ca header.b=gQD2MSrR; dkim-adsp=pass
X-Virus-Scanned: amavisd-new at mx.nohats.ca
Received: from mx.nohats.ca ([IPv6:::1]) by localhost (mx.nohats.ca [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id h2FwDptmZvKY; Mon, 9 Mar 2015 21:01:13 +0100 (CET)
Received: from bofh.nohats.ca (206-248-139-105.dsl.teksavvy.com [206.248.139.105]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx.nohats.ca (Postfix) with ESMTPS; Mon, 9 Mar 2015 21:01:13 +0100 (CET)
Received: from bofh.nohats.ca (bofh.nohats.ca [127.0.0.1]) by bofh.nohats.ca (Postfix) with ESMTP id 579DF80416; Mon, 9 Mar 2015 16:01:12 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nohats.ca; s=default; t=1425931272; bh=OKBrJhCYhfuB/YrXrD8r+S3DvhhAcgatg1oah2ZLgmc=; h=Date:From:To:cc:Subject:In-Reply-To:References; b=gQD2MSrRGcya17Lc7q7i7F7KD+jgxG6TBe+RBQYxLKB4VD5qw+DMwIOHWvQ+sHq8O 2o8N7tUadVOeGnnvYDYo+Q3oj6GoKRLquE4z+EZoQmlDaHQdjmHvkHv/5tTHtWLXrX D21MvLtF2x9FAFD1bUk0F3YjKplgle4G5Gt2z7qA=
Received: from localhost (paul@localhost) by bofh.nohats.ca (8.14.7/8.14.7/Submit) with ESMTP id t29K1B9O013001; Mon, 9 Mar 2015 16:01:12 -0400
X-Authentication-Warning: bofh.nohats.ca: paul owned process doing -bs
Date: Mon, 09 Mar 2015 16:01:11 -0400
From: Paul Wouters <paul@nohats.ca>
To: Alexey Melnikov <alexey.melnikov@isode.com>
In-Reply-To: <54FDF0CB.5070203@isode.com>
Message-ID: <alpine.LFD.2.10.1503091600001.29875@bofh.nohats.ca>
References: <CAHw9_iJPuG23Aok7V_wcAMirua_DPDLHy01tnd+DaUqEeK3NZA@mail.gmail.com> <CAHw9_iKU=inVWUJkj4oR7zc5Fh-ejJRpLfURaeF8J4AxCcz_BQ@mail.gmail.com> <54FDF0CB.5070203@isode.com>
User-Agent: Alpine 2.10 (LFD 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset="US-ASCII"; format="flowed"
Archived-At: <http://mailarchive.ietf.org/arch/msg/dane/JVIQ7gi-Upy08i0g3yhDk8I4qiQ>
Cc: "<dane@ietf.org>" <DANE@ietf.org>
Subject: Re: [dane] Start of WGLC for draft-ietf-dane-openpgpkey - *please* review.
X-BeenThere: dane@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DNS-based Authentication of Named Entities <dane.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dane>, <mailto:dane-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/dane/>
List-Post: <mailto:dane@ietf.org>
List-Help: <mailto:dane-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dane>, <mailto:dane-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Mar 2015 20:01:22 -0000

On Mon, 9 Mar 2015, Alexey Melnikov wrote:

> The document looks good to me and I support its publication.

Great :)

> Some nits/minor things:
>
> 2.3.  The OPENPGPKEY RDATA presentation format
>
>   The RDATA Presentation Format, as visible in textual zone files,
>   consists of a single OpenPGP public key as defined in
>   Section 5.5.1.1. of [RFC4880] encoded in Base64 [RFC4648]
>
> The base64 section should say "Section 4 of [RFC4648]". Because there is 
> also section 5, which uses a diffent alphabet.

Fixed for -03.

> In 3.1:
>
> o  Everything after a "+" symbol is dynamc.
>
> Typo: dynamic.

Fixed for -03

> If you want an informative reference here, you can reference RFC 5233.

Added for -03.

Thanks!

Paul