Re: [Ntp] Antw: [EXT] Re: Quick review of WGLC for status change for draft‑ietf‑ntp‑update‑registries

Miroslav Lichvar <mlichvar@redhat.com> Mon, 08 August 2022 12:58 UTC

Return-Path: <mlichvar@redhat.com>
X-Original-To: ntp@ietfa.amsl.com
Delivered-To: ntp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 88830C157901 for <ntp@ietfa.amsl.com>; Mon, 8 Aug 2022 05:58:47 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.389
X-Spam-Level:
X-Spam-Status: No, score=-3.389 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.582, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HajyStRqbuFW for <ntp@ietfa.amsl.com>; Mon, 8 Aug 2022 05:58:47 -0700 (PDT)
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E3DD0C14F74E for <ntp@ietf.org>; Mon, 8 Aug 2022 05:58:46 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1659963525; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9PaMiyD5VgKOEMzBwHYyela7ayAhS11gTqobWXSRaQ8=; b=iKFzel4OjqPsVMPC/UjVpOA838zzEct4dg88P3Edz4JvT2K3EKxU63bV9Tzvc01GeqnM9C x3AuGsMce4SuYeLmmyen55Hb31bFTeKR2URG+Iq8GL3ifXnKLKiDzVF3poFFZ7BmHt8vU3 avYhaVa3H5lTzuL59H6ddw95lG9DGpY=
Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-483-HO3AZExpOfir0PRkHXJVlQ-1; Mon, 08 Aug 2022 08:58:42 -0400
X-MC-Unique: HO3AZExpOfir0PRkHXJVlQ-1
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9A9AF1C00AC1; Mon, 8 Aug 2022 12:58:41 +0000 (UTC)
Received: from localhost (unknown [10.43.135.229]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E367494585; Mon, 8 Aug 2022 12:58:40 +0000 (UTC)
Date: Mon, 08 Aug 2022 14:58:39 +0200
From: Miroslav Lichvar <mlichvar@redhat.com>
To: Harlan Stenn <stenn@nwtime.org>
Cc: Ulrich Windl <Ulrich.Windl@rz.uni-regensburg.de>, "ntp@ietf.org" <ntp@ietf.org>, odonoghue@isoc.org
Message-ID: <YvEIf3g+Jjm27pUz@localhost>
References: <PH0PR06MB7061FA7A5B338D262B3A2963C2999@PH0PR06MB7061.namprd06.prod.outlook.com> <6a187a2f-9883-2fb5-1f51-1593591ddebb@nwtime.org> <PH0PR06MB706126984E4442EF32F8242AC2999@PH0PR06MB7061.namprd06.prod.outlook.com> <da155c84-2c70-2e3b-59eb-03e380806cf2@nwtime.org> <PH0PR06MB70611F2331D8255F7E2B6604C2999@PH0PR06MB7061.namprd06.prod.outlook.com> <0b4c7efa-3977-b588-0974-33b6a9437e52@nwtime.org> <62F0E9D3020000A10004C2EC@gwsmtp.uni-regensburg.de> <2d66fa3e-f750-e3d2-511e-594fa40d993d@nwtime.org> <62F0F4C7020000A10004C310@gwsmtp.uni-regensburg.de> <8faf7c64-8896-97ca-fa2e-2d762c7da1d8@nwtime.org>
MIME-Version: 1.0
In-Reply-To: <8faf7c64-8896-97ca-fa2e-2d762c7da1d8@nwtime.org>
X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
Archived-At: <https://mailarchive.ietf.org/arch/msg/ntp/VqJT4xcqACPuNaXMZYmaJXmeWa8>
Subject: Re: [Ntp] Antw: [EXT] Re: Quick review of WGLC for status change for draft‑ietf‑ntp‑update‑registries
X-BeenThere: ntp@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Network Time Protocol <ntp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ntp>, <mailto:ntp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ntp/>
List-Post: <mailto:ntp@ietf.org>
List-Help: <mailto:ntp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ntp>, <mailto:ntp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Aug 2022 12:58:47 -0000

On Mon, Aug 08, 2022 at 04:48:16AM -0700, Harlan Stenn wrote:
> I was easily able to have the new code auto-detect if an NTP packet was:
> 
> - just a base packet
> - a base packet with a legacy MAC
> - a base packet with EFs and a legacy MAC
> - a base packet with EFs and a MAC-EF
> 
> No trouble at all.  And none of the above needed the extended EF size
> required by 7822.

We discussed this before, more than once.

If you allow short extension fields, you will not be able to detect
whether a request contains an unknown extension field or an Autokey
MAC using an old cookie. The protocol may be able recover, but that's
not how things should be done.

Here is an example:

04 1b 00 14 cc e2 c8 47 71 95 79 64 c4 71 e8 72 7e bf fb cd

Which of the two is it?

-- 
Miroslav Lichvar