Re: [Idr] WG adoption call for draft-abraitis-bgp-version-capability-08, to end September 25

Robert Raszuk <robert@raszuk.net> Mon, 16 January 2023 19:39 UTC

Return-Path: <robert@raszuk.net>
X-Original-To: idr@ietfa.amsl.com
Delivered-To: idr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id AF5CAC151520 for <idr@ietfa.amsl.com>; Mon, 16 Jan 2023 11:39:32 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.095
X-Spam-Level:
X-Spam-Status: No, score=-7.095 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=raszuk.net
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 46mBxUIcI0wy for <idr@ietfa.amsl.com>; Mon, 16 Jan 2023 11:39:29 -0800 (PST)
Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0F8ECC14CE3D for <idr@ietf.org>; Mon, 16 Jan 2023 11:39:29 -0800 (PST)
Received: by mail-wr1-x42d.google.com with SMTP id r9so5699763wrw.4 for <idr@ietf.org>; Mon, 16 Jan 2023 11:39:28 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raszuk.net; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=5ulM78qbzKcp+H7cyJJ7Ph0j0Kjuh0w1k8oRzG8Y9OA=; b=RjrdBq4rCe5VcTRPS7+JSsQEVNWgnkbeUagK9NFnr9R8wo/fkRb/eHsrRDEUQWUH9s e5/hc1ylrUbLC3EcAkW4UmJju2g1ZacDC40EJHmHywVqVghfQiCTosoyzXsvQggOaIol SuzHt33/1DXkXo5qsSd41WC1lhL0Vd5nXc5bP9E0YJsAhWzmNu2LlrYhkDBSMzx04P8e 67seW1yVVmOSj9QVkJsf3OJKc5W5txZ+Q6briKtJ0dyEc3CZch1LpdxVPXCIJ8Q7/Pgr 0Zzu8Uoz0ga2T3/NjbEsbvacWiQ4BtzS2iPgYNUbbdTY4M0pIz6SM12y4801cNQ8ctoT q1VQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5ulM78qbzKcp+H7cyJJ7Ph0j0Kjuh0w1k8oRzG8Y9OA=; b=RIcMDyRdUS6nmhC7u7NTOHYytNf5uyaFAVPlJjgcvURnc9ATn0agfvWVYLFlOX61oB mAouqbYdH68u6UfFuT9/5dtYrz2ishOZTir3qo0lAE7Ys1ommfvjFv4z1FT+/zsnRQz6 9lHGc701D9KGODuFcnczd3bcGosAwDhJECCC9iBrMQT+lSo/DUj8toqQDy0V8J3PtdUf 4Ls1MkKTjGyTxjP7yYTIoyxLrMkfy+RLb9fBkEuwJ70Rze2JMBHhb2Zg+Ldz0aWQWkq1 0h8SFBfuhgfYNBjMh4Pn8WlSArTsAgntFb8iC5FFnaTSiCrBtEUVfKOQdq73bdNuQc9x NouA==
X-Gm-Message-State: AFqh2kpCRZBxJbNCrjMKYl93occDhqUdugkx9pT4sjDDJ11TYHlC3Tw5 OLoTMlA51rISRppyfPhWXbsKuq/NR6n64loCjb4QSQ==
X-Google-Smtp-Source: AMrXdXtJkdtCoAB5wlIitEclLHesxhQXT0fELAWv7+BFw+H61BDLR2g6Sk5vX0hp2oKEa+YGnz8E7FyMZE79288yxa0=
X-Received: by 2002:adf:a3d9:0:b0:242:72d6:7708 with SMTP id m25-20020adfa3d9000000b0024272d67708mr30684wrb.157.1673897967059; Mon, 16 Jan 2023 11:39:27 -0800 (PST)
MIME-Version: 1.0
References: <CAOj+MMG9BuCBjATYNKO5H0oFUipCE8iBU+DJ0FLDDUZdp+nM3Q@mail.gmail.com> <Y77nmDKUgCUyhJ5W@diehard.n-r-g.com> <C3B4F29D-7C8D-4911-B140-286B7B8DA97B@pfrc.org> <CAOj+MMGmSBDwbxvSZ_x+j7NtCHRFFFvcCEKGJ0Wpis_OU26cLA@mail.gmail.com> <CABNhwV3qwCT8=8R+HTi1DFhbRN=FwHMF4XvQVowQwz=pb2U-nA@mail.gmail.com> <CAOj+MMG-5TT2sEnZVMabP1wA=gBNH0g9zkpoM9LWL7XFnh2aEQ@mail.gmail.com> <CABNhwV2H8Y7pthkWtJsDUN7ZscjGvc+v2XdpZ5CcG2ot9TBBog@mail.gmail.com> <CO1PR13MB492093DC7492BFD14A47C97B85C29@CO1PR13MB4920.namprd13.prod.outlook.com> <CABNhwV2UL0ruFeJwfwPnP7OWO9qCpHw3ubWNF7BoQQUEYEgZRw@mail.gmail.com> <CO1PR13MB4920CBF456034CE08D70691385C19@CO1PR13MB4920.namprd13.prod.outlook.com> <20230116192152.GA19126@pfrc.org> <CAOj+MMFAkworqATpiykEMKbntTt7z5kFMOiMNhvj1Z6EG9UAcQ@mail.gmail.com> <CAPF+HwV9fTBAPqiSGUZBOuoqL+abdyMmereyMZwvmKPXTF047w@mail.gmail.com>
In-Reply-To: <CAPF+HwV9fTBAPqiSGUZBOuoqL+abdyMmereyMZwvmKPXTF047w@mail.gmail.com>
From: Robert Raszuk <robert@raszuk.net>
Date: Mon, 16 Jan 2023 20:39:16 +0100
Message-ID: <CAOj+MMHLnfdCwmtusEYGkJy0m7=zRrVLtcrE67pjegPN2nFoLw@mail.gmail.com>
To: Donatas Abraitis <donatas.abraitis@gmail.com>
Cc: Jeffrey Haas <jhaas@pfrc.org>, "idr@ietf.org" <idr@ietf.org>, Linda Dunbar <linda.dunbar@futurewei.com>
Content-Type: multipart/alternative; boundary="000000000000b79b8005f266bd60"
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/ewn0JAJeotKt2sw_6b9M_BOfpjM>
Subject: Re: [Idr] WG adoption call for draft-abraitis-bgp-version-capability-08, to end September 25
X-BeenThere: idr@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Inter-Domain Routing <idr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/idr>, <mailto:idr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr/>
List-Post: <mailto:idr@ietf.org>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/idr>, <mailto:idr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Jan 2023 19:39:32 -0000

Right and I think this is good. I do not like sending anything into vacuum.

For clarity to some folks: That includes BGP OPEN Optional Parameter Type 2
as well.

The below was more referring to Linda's question.

Cheers,
R.

On Mon, Jan 16, 2023 at 8:34 PM Donatas Abraitis <donatas.abraitis@gmail.com>
wrote:

> I can speak on FRR, the implementation resets the session if an
> unrecognized BGP OPEN optional parameter is received.
>
> On Mon, Jan 16, 2023 at 9:28 PM Robert Raszuk <robert@raszuk.net> wrote:
>
>> I am afraid you are talking about BGP version while Linda is asking about
>> the subject draft bgp version ... Both are completely unrelated "versions".
>>
>> While we are here I did reread RFC4271 and I am not sure either if there
>> is text to mandate closing the session when new BGP OPEN Optional Parameter
>> is not recognized. Neither does FSM. Generating NOTIFICATION and continue
>> should be allowed by the spec unless I missed some embedded mandate to
>> close it.
>>
>> Thx,
>> R.
>>
>> On Mon, Jan 16, 2023 at 8:21 PM Jeffrey Haas <jhaas@pfrc.org> wrote:
>>
>>> Linda,
>>>
>>> On Mon, Jan 16, 2023 at 06:54:29PM +0000, Linda Dunbar wrote:
>>> > RFC4271 states that if the version number is not supported, an error
>>> message should be sent. But RFC4271 didn't say if the BGP Open session
>>> should be failed.
>>> > I am just curious if BGP session can be started even if the  version
>>> number is not supported?
>>>
>>> RFC 4271, §6.2:
>>> : 6.2.  OPEN Message Error Handling
>>> :
>>> :    All errors detected while processing the OPEN message MUST be
>>> :    indicated by sending the NOTIFICATION message with the Error Code
>>> :    OPEN Message Error.  The Error Subcode elaborates on the specific
>>> :    nature of the error.
>>> :
>>> :    If the version number in the Version field of the received OPEN
>>> :    message is not supported, then the Error Subcode MUST be set to
>>> :    Unsupported Version Number.  The Data field is a 2-octet unsigned
>>> :    integer, which indicates the largest, locally-supported version
>>> :    number less than the version the remote BGP peer bid (as indicated
>>> in
>>> :    the received OPEN message), or if the smallest, locally-supported
>>> :    version number is greater than the version the remote BGP peer bid,
>>> :    then the smallest, locally-supported version number.
>>>
>>> Tersely, if you don't support the right version number, you hang up the
>>> session with a NOTIFICATION and leave enough of a breadcrumb that the
>>> next
>>> OPEN could arrive at a possibly mutually supported version.
>>>
>>> -- Jeff
>>>
>> _______________________________________________
>> Idr mailing list
>> Idr@ietf.org
>> https://www.ietf.org/mailman/listinfo/idr
>>
>
>
> --
> Donatas
>