Re: [Idr] WG adoption call for draft-abraitis-bgp-version-capability-08, to end September 25

Jeffrey Haas <jhaas@pfrc.org> Mon, 16 January 2023 20:01 UTC

Return-Path: <jhaas@slice.pfrc.org>
X-Original-To: idr@ietfa.amsl.com
Delivered-To: idr@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5B9AAC14CE4B for <idr@ietfa.amsl.com>; Mon, 16 Jan 2023 12:01:51 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cOlMiEddiFsE for <idr@ietfa.amsl.com>; Mon, 16 Jan 2023 12:01:49 -0800 (PST)
Received: from slice.pfrc.org (slice.pfrc.org [67.207.130.108]) by ietfa.amsl.com (Postfix) with ESMTP id 2650BC1524DA for <idr@ietf.org>; Mon, 16 Jan 2023 12:00:28 -0800 (PST)
Received: by slice.pfrc.org (Postfix, from userid 1001) id C83861E399; Mon, 16 Jan 2023 15:00:26 -0500 (EST)
Date: Mon, 16 Jan 2023 15:00:26 -0500
From: Jeffrey Haas <jhaas@pfrc.org>
To: Robert Raszuk <robert@raszuk.net>
Cc: Linda Dunbar <linda.dunbar@futurewei.com>, Gyan Mishra <hayabusagsm@gmail.com>, "idr@ietf.org" <idr@ietf.org>
Message-ID: <20230116200025.GA21068@pfrc.org>
References: <CABNhwV3qwCT8=8R+HTi1DFhbRN=FwHMF4XvQVowQwz=pb2U-nA@mail.gmail.com> <CAOj+MMG-5TT2sEnZVMabP1wA=gBNH0g9zkpoM9LWL7XFnh2aEQ@mail.gmail.com> <CABNhwV2H8Y7pthkWtJsDUN7ZscjGvc+v2XdpZ5CcG2ot9TBBog@mail.gmail.com> <CO1PR13MB492093DC7492BFD14A47C97B85C29@CO1PR13MB4920.namprd13.prod.outlook.com> <CABNhwV2UL0ruFeJwfwPnP7OWO9qCpHw3ubWNF7BoQQUEYEgZRw@mail.gmail.com> <CO1PR13MB4920CBF456034CE08D70691385C19@CO1PR13MB4920.namprd13.prod.outlook.com> <20230116192152.GA19126@pfrc.org> <CAOj+MMFAkworqATpiykEMKbntTt7z5kFMOiMNhvj1Z6EG9UAcQ@mail.gmail.com> <20230116194512.GA20268@pfrc.org> <CAOj+MMFxgZs6q3=Wi3EaO4rxEgyTpgnzfcthraSvx7rBf9sRqA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAOj+MMFxgZs6q3=Wi3EaO4rxEgyTpgnzfcthraSvx7rBf9sRqA@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/zqD4z5HVwq6KLOG7Y3t-MafjCpA>
Subject: Re: [Idr] WG adoption call for draft-abraitis-bgp-version-capability-08, to end September 25
X-BeenThere: idr@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Inter-Domain Routing <idr.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/idr>, <mailto:idr-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/idr/>
List-Post: <mailto:idr@ietf.org>
List-Help: <mailto:idr-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/idr>, <mailto:idr-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Jan 2023 20:01:51 -0000

On Mon, Jan 16, 2023 at 08:49:46PM +0100, Robert Raszuk wrote:
> >
> > RFC 4271, §6.2:
> >
> > :    If one of the Optional Parameters in the OPEN message is not
> > :    recognized, then the Error Subcode MUST be set to Unsupported
> > :    Optional Parameters.
> 
> 
> Yes I have see it. But what I was nto able to find was a statement that
> ALL Errors MUST result in dropping the TCP session.
> 
> Note that I am all for it and not questioning it. Just was curious
> where is this explicitly written in the base spec.

I'll do this bit of your homework for you, but I'm not going to dig deeply
here through all of the edge cases.  There are bugs in the FSM text.  I have
already lost too much of my life previously finding and reporting them.
Unfortunately my notes are two jobs ago gone and it'll be up to someone else
to spend their time finding the nits.  Mostly because the earlier text from
RFC 1771 was good enough for most cases and it's usually obvious what you
should do.

(Thanks, Alex...)

:       If BGP message header checking (Event 21) or OPEN message checking
:       detects an error (Event 22) (see Section 6.2), the local system:
: 
:         - (optionally) If the SendNOTIFICATIONwithoutOPEN attribute is
:           set to TRUE, then the local system first sends a NOTIFICATION
:           message with the appropriate error code, and then
: 
:         - stops the ConnectRetryTimer (if running) and sets the
:           ConnectRetryTimer to zero,
: 
:         - releases all BGP resources,
: 
:         - drops the TCP connection,
: 
:         - increments the ConnectRetryCounter by 1,
: 
:         - (optionally) performs peer oscillation damping if the
:           DampPeerOscillations attribute is set to TRUE, and
: 
:         - changes its state to Idle.

-- Jeff