IETF Logo Mail Archive

Re: [quicwg/base-drafts] Spin per peer (#1982)

mirjak <notifications@github.com> Tue, 27 November 2018 15:34 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 815AC130DDA for <quic-issues@ietfa.amsl.com>; Tue, 27 Nov 2018 07:34:45 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.46
X-Spam-Level:
X-Spam-Status: No, score=-4.46 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YzfLXlu7ekSB for <quic-issues@ietfa.amsl.com>; Tue, 27 Nov 2018 07:34:43 -0800 (PST)
Received: from o11.sgmail.github.com (o11.sgmail.github.com [167.89.101.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7DCA412D4E7 for <quic-issues@ietf.org>; Tue, 27 Nov 2018 07:34:43 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=dnGoD4L/zAoibww6nimXT7Tto2w=; b=caRBVRgaKNz4qe2R D4kOzA6mApaGvHbui8RxK0oaWCO3cDG2TaFqGWfl7AythjAggJLLgetn6zginTh2 gmSb79mIF/wGYkrMXeZ0Qxwz02GjYEScxPEyyB41H933qhUN7Sbxup1/EyeUKhdE YjqgWdAFSmA8ShsJXdlpKWdTU+c=
Received: by filter0028p1iad2.sendgrid.net with SMTP id filter0028p1iad2-4543-5BFD6412-16 2018-11-27 15:34:42.380700525 +0000 UTC m=+857813.461845778
Received: from github-lowworker-39ccb07.cp1-iad.github.net (unknown [192.30.252.40]) by ismtpd0019p1iad2.sendgrid.net (SG) with ESMTP id ad4FCfDgQ_SihD1W5_ArCg for <quic-issues@ietf.org>; Tue, 27 Nov 2018 15:34:42.417 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-39ccb07.cp1-iad.github.net (Postfix) with ESMTP id 5F76C4017E0 for <quic-issues@ietf.org>; Tue, 27 Nov 2018 07:34:42 -0800 (PST)
Date: Tue, 27 Nov 2018 15:34:42 +0000
From: mirjak <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab40cc2ad65135fd05c7bb71841ebf814113bc87f692cf000000011815261292a169ce169265bd@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1982/review/178848692@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1982@github.com>
References: <quicwg/base-drafts/pull/1982@github.com>
Subject: Re: [quicwg/base-drafts] Spin per peer (#1982)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bfd64125ce6e_f193fddd0ad45c45285c6"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mirjak
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0KeAdx1FzvaSbMn9Kk0/+tNhdkaXEo/KjGSs cFB5n8y9xTnxYqB0n6SBUlwVhta8FuyiPpg05JPiQDlvV8b9V7Gq/Cy1sFKEjPCHT5yY/lAUlpKzB7 iz5ZBaaBlC9oF35gn7MYIM6TprYHOdciWwYltNdh2vEdQbWUEgVZ1XfsyA==
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/ShZgct40fuaLlmjvn-SRIextFA8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Nov 2018 15:34:46 -0000

mirjak commented on this pull request.



> @@ -244,11 +244,8 @@ on the source and destination addresses of the path,
 so that the spin bit is consistently enabled or
 disabled for repeated use of the same path.
 

Sorry to re-open this conversation but the spin should really be set to zero and not random per packet or anything like that because this makes it harder to impossible to detect valid spinning signals in the network and may render the valid spin signal useless for aggreates.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1982#pullrequestreview-178848692

v2.23.0 | Report a Bug | By Email