Re: [quicwg/base-drafts] Spin per peer (#1982)

Christian Huitema <notifications@github.com> Sun, 25 November 2018 20:48 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 713211288EB for <quic-issues@ietfa.amsl.com>; Sun, 25 Nov 2018 12:48:08 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.461
X-Spam-Level:
X-Spam-Status: No, score=-4.461 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TRNtF1m_MfPp for <quic-issues@ietfa.amsl.com>; Sun, 25 Nov 2018 12:48:06 -0800 (PST)
Received: from o8.sgmail.github.com (o8.sgmail.github.com [167.89.101.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3BF321277C8 for <quic-issues@ietf.org>; Sun, 25 Nov 2018 12:48:06 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=KNtkwgPbKUexVVpeqqCdpNcFvy8=; b=O8henHCgyJ0Ql9B6 +C3WPzZOBO9tFzGW3E2qzue7C62WtfWCl3iXVQGA5sr3qMr01IOtqasKjzGXmhqR jyC5t7wDqKlmCGhnERCHtSbrzgV5mBH3T2poSdkuqx98fZz3otiHBcx4WrvVU852 8zoUk7wF6oJwnFGbjCgoph5RW4o=
Received: by filter1545p1mdw1.sendgrid.net with SMTP id filter1545p1mdw1-3060-5BFB0A85-5 2018-11-25 20:48:05.193648098 +0000 UTC m=+853616.898577678
Received: from github-lowworker-cef7735.cp1-iad.github.net (unknown [192.30.252.35]) by ismtpd0005p1iad2.sendgrid.net (SG) with ESMTP id 1fSNDO4mTCGGVmwjEahj9A for <quic-issues@ietf.org>; Sun, 25 Nov 2018 20:48:05.221 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-cef7735.cp1-iad.github.net (Postfix) with ESMTP id 0F4351E0050 for <quic-issues@ietf.org>; Sun, 25 Nov 2018 12:48:05 -0800 (PST)
Date: Sun, 25 Nov 2018 20:48:05 +0000
From: Christian Huitema <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab32e4c2cf104b53b2077b642762e269551df3b89492cf000000011812cc8592a169ce169265bd@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1982/review/178096558@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1982@github.com>
References: <quicwg/base-drafts/pull/1982@github.com>
Subject: Re: [quicwg/base-drafts] Spin per peer (#1982)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bfb0a85dbe6_565d3fae17cd45c4816e"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: huitema
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak2R4KXWm8jktkbZHcmj/eoLlHY5w5XUSliNsz v9K5So38ZHo30ChFZvtD2czzzAbzy+OuKrzPdBbe7TWXeJ8ADzYLsX41OBb80ZlFCe1gXtktM80/C7 uxn7ZNkj2uuqGdWsOIzAKKC3wmTOevzdG6WQp7s6ws8YwdgfUMC7kKub2/cmEW3qa8jxrkSQOygk1t U=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/csB50vrnd47bOTlz2uEiQsY8jh4>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 25 Nov 2018 20:48:09 -0000

huitema commented on this pull request.



> -
-When the spin bit is disabled, endpoints SHOULD set the spin bit value to zero,
-regardless of the values received from their peer. Addendums or revisions to
+fraction of connections.
+
+The selection process SHOULD be designed such that
+on average the spin bit is disabled for at least one eighth of network paths.
+The random choice SHOULD be dependent
+on the source and destination addresses of the path,
+so that the spin bit is consistently enabled or
+disabled for repeated use of the same path.
+
+When the spin bit is disabled, endpoints SHOULD set the spin bit value to
+a constant value randomly chosen to be 0 or 1,
+regardless of the values received from their peer.  Alternatively, endpoints MAY
+change this value when changing connection ID.  Addendums or revisions to

@EKR Removing text is easy, and I would be willing to do that if there is consensus. But I would like to hear another couple of voices advocating that -- say @martinthomson or @kazuho, who expressed opinions on the subject before.

As for PNRG,  it cannot be the PNE mask for the spin bit. The spin bit is protected by the AEAD checksum and has to be set before AEAD protection. The PNE mask is computed using the AEAD output, and is not available in time for randomizing the spin bit.  

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1982#discussion_r236089415