Re: [tsvwg] Review comments on a careful read of the L4S ID (#14. network node)

Bob Briscoe <ietf@bobbriscoe.net> Fri, 14 May 2021 16:09 UTC

Return-Path: <ietf@bobbriscoe.net>
X-Original-To: tsvwg@ietfa.amsl.com
Delivered-To: tsvwg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B661B3A3793 for <tsvwg@ietfa.amsl.com>; Fri, 14 May 2021 09:09:34 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.433
X-Spam-Level:
X-Spam-Status: No, score=-1.433 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, NICE_REPLY_A=-0.001, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=bobbriscoe.net
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id t9cIEMnerZWj for <tsvwg@ietfa.amsl.com>; Fri, 14 May 2021 09:09:29 -0700 (PDT)
Received: from mail-ssdrsserver2.hosting.co.uk (mail-ssdrsserver2.hosting.co.uk [185.185.85.90]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7AC0C3A378E for <tsvwg@ietf.org>; Fri, 14 May 2021 09:09:29 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=bobbriscoe.net; s=default; h=Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=fMFVnKZPD7JbzAN1C6K6xkuRzdR9DxVuiHVAZUzHXbk=; b=A8WqWDba7/I5wg6dqe+3TmuyUq 9qgMJ4Fba1el8+QdFjPeRiIiJn4vXCkgZOzylw5wLn1OXfL3cDPqD+F07J0T5D2kFcA18eIYQXV2g HyajFs3CZO3nC6c8Jaqo+P4UtznDkO06/gI8HKk44CwpzuCgejpjRjQXRchJQ+mBWOQx1SOGWUDDQ R+VJWLmmvjQL0Is+mWMPAs4FprfI+inOOCpBrlaFP2u3RrmI6B97/95LCloCLi5ePd7eBy9TeTAK7 XnmGapNVHDPts6Zj2jI9dmyebtsfEg8b75P0MRb6FTeFKdsMotGT2uUg2fvNTmPJGNg19K/FV6BBb 2VowpPYg==;
Received: from 67.153.238.178.in-addr.arpa ([178.238.153.67]:54146 helo=[192.168.1.11]) by ssdrsserver2.hosting.co.uk with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from <ietf@bobbriscoe.net>) id 1lhaNV-0005sQ-Ju; Fri, 14 May 2021 17:09:27 +0100
To: "Black, David" <David.Black@dell.com>, Gorry Fairhurst <gorry@erg.abdn.ac.uk>
Cc: "tsvwg@ietf.org" <tsvwg@ietf.org>
References: <634676ca-272d-d616-c352-b38446cf7aab@erg.abdn.ac.uk> <daa2dbec-1e62-83a3-c392-265e948d9b83@bobbriscoe.net> <MN2PR19MB404512380B708B63CCC5804183509@MN2PR19MB4045.namprd19.prod.outlook.com>
From: Bob Briscoe <ietf@bobbriscoe.net>
Message-ID: <eb7aadde-fcd1-5db1-377f-d43fd3e71a6a@bobbriscoe.net>
Date: Fri, 14 May 2021 17:09:25 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1
MIME-Version: 1.0
In-Reply-To: <MN2PR19MB404512380B708B63CCC5804183509@MN2PR19MB4045.namprd19.prod.outlook.com>
Content-Type: multipart/alternative; boundary="------------8EEF1A423FEE7275546908D8"
Content-Language: en-GB
X-AntiAbuse: This header was added to track abuse, please include it with any abuse report
X-AntiAbuse: Primary Hostname - ssdrsserver2.hosting.co.uk
X-AntiAbuse: Original Domain - ietf.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - bobbriscoe.net
X-Get-Message-Sender-Via: ssdrsserver2.hosting.co.uk: authenticated_id: in@bobbriscoe.net
X-Authenticated-Sender: ssdrsserver2.hosting.co.uk: in@bobbriscoe.net
X-Source:
X-Source-Args:
X-Source-Dir:
Archived-At: <https://mailarchive.ietf.org/arch/msg/tsvwg/bDH8HryjuhzXy-Jn_VtvODJmBkM>
Subject: Re: [tsvwg] Review comments on a careful read of the L4S ID (#14. network node)
X-BeenThere: tsvwg@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Transport Area Working Group <tsvwg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/tsvwg>, <mailto:tsvwg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/tsvwg/>
List-Post: <mailto:tsvwg@ietf.org>
List-Help: <mailto:tsvwg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/tsvwg>, <mailto:tsvwg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 14 May 2021 16:09:36 -0000

David,

On 14/05/2021 16:05, Black, David wrote:
>
> Top posting to make this quick to read – this concern is resolved by 
> the following revised Section 5.1 text (in -16):
>
> A network node that implements the L4S service:
>
> o  MUST classify arriving ECT(1) packets for L4S treatment, unless
>
> overridden by a another classifier (e.g., see Section 5.4.1.2 
> <https://datatracker.ietf.org/doc/html/draft-ietf-tsvwg-ecn-l4s-id-16#section-5.4.1.2>);
>
> o  MUST classify arriving CE packets for L4S treatment as well,
>
> unless overridden by a another classifier or unless the exception
>
> referred to next applies;
>
> The use of "another classifier" allows use of other criteria to 
> include/exclude ECT(1) and CE packets for L4S treatment. The exception 
> that follows is use of a flow-aware mechanism to distinguish CE 
> packets for L4S flows from those for non-L4S flows and only apply L4S 
> treatment to CE packets for L4S flows.
>
> Nit: "a another" -> "another" (twice).
>

[BB] Done.

Thx

bob

> Thanks, --David
>
> *From:* Bob Briscoe <ietf@bobbriscoe.net>
> *Sent:* Friday, May 14, 2021 9:47 AM
> *To:* Gorry Fairhurst; Black, David
> *Cc:* tsvwg@ietf.org
> *Subject:* Re: [tsvwg] Review comments on a careful read of the L4S ID 
> (#14. network node)
>
> [EXTERNAL EMAIL]
>
> David, Gorry,
>
> On 06/05/2021 07:52, Gorry Fairhurst wrote:
>
>     =================================================================
>     *14. Replace “network node”  (part 1)*
>
>     This text:
>     “ A network node that implements the L4S service always classifies
>        arriving ECT(1) packets for L4S treatment and by default classifies
>        CE packets for L4S treatment unless the heuristics described in
>        Section 5.3 are employed.”
>
>     ⁃Use of “network node” is excessive and over-constrains
>     implementations, e.g., the techniques in Sections 5.4.1.2 and
>     5.4.1.3 conflict with this sentence.  Change “A network node that
>     implements” to “An implementation of the L4S service” It would be
>     nice to be at least clear this is marking behaviour, e.g. “An
>     implementation that marks using L4S”, or something similar.
>     =================================================================*
>     20.  Reduce “network node” scope (part 2)*
>
>     In section 5.1:
>     “A network node that implements the L4S service MUST classify arriving
>       ECT(1) packets for L4S treatment and, other than in the exceptional
>        case referred to next, it MUST classify arriving CE packets for L4S
>        treatment as well.”
>
>     ⁃Please change to “An implementation of the L4S service MUST
>     classify …”  This removes conflicts with at least Sections 5.4.1.2
>     and 5.4.1.3.
>     =================================================================
>     *21. Reduce “network node” scope (part 3)*
>
>     This text:
>     “ For backward compatibility in uncontrolled environments, a network
>        node that implements the L4S treatment MUST also implement an AQM
>        treatment for the Classic service as defined in Section 1.2.”
>
>     ⁃Change to “an implementation of the L4S service that supports the
>     L4S treatment MUST also implement …”  This removes conflicts with
>     at least Sections 5.4.1.2 and 5.4.1.3.
>     =================================================================
>     *23. What about if a sender uses Not-ECT and ECT(0) in
>     combination? Also, reduce “network node” scope (part 4)*
>     This text:
>     “Nonetheless, if an implementer is
>        willing to identify transport-layer flows at a network node, and if
>        the most recent ECT packet in the same flow was ECT(0), the
>     node MAY
>        classify CE packets for Classic ECN [RFC3168] treatment.”
>     ⁃Please tell us if you have thought about when the previous packet
>     was not-ECT. Has this been considered and is it explicitly
>     required to then send a CE mark via the L4S queue? I understand
>     the next para to speak only about when next packet was ECT(1).
>     ⁃See other note on “at a network node” and change “the node may”
>     to “the implementation MAY”.  This removes conflicts with at least
>     Sections 5.4.1.2 and 5.4.1.3.
>     ⁃It would also help to change “if an implementer is willing” to
>     “if an implementation is able”.
>     ⁃If the latter is done, change “If an implementer uses” to “If an
>     implementation uses” at the start of the next paragraph.
>     =================================================================
>
>
> [BB] For the record, I believe these concerns were resolved offlist to 
> reduce noise, and the resolutions are already included in draft-16, by 
> referring forward to exceptions defined later in S.5.1, and in 5.1 
> making those exceptions clearer and more complete.
>
> Please confirm whether the text in -16 is now acceptable.
>
>
> Bob
>
>
> -- 
> ________________________________________________________________
> Bob Briscoehttp://bobbriscoe.net/ [bobbriscoe.net]  <https://urldefense.com/v3/__http:/bobbriscoe.net/__;!!LpKI!1enWVfZ8juwUTPZhR8eDn_Cawae1UGNlkNx5uU75k0CGy_jA23R8zDakSDZR4KwS$>

-- 
________________________________________________________________
Bob Briscoe                               http://bobbriscoe.net/